-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the --comp option in appimagetool #69
Comments
Hi @pkwong4321, thanks for your comment. However, we are standardizing (no pun intended) on zstd. So if you need AppImageLauncher, it might be a good idea to ask its developers to support zstd. |
Just want to say the binary distributed here does not work with anything other than zstd, specified or not. If you want to standardize with zstd, you might want to remove the --comp option in appimagetool? |
Yes, good idea. Thanks! |
Note that removing the --comp option will break workflows that are already using --comp zstd. |
Good point... |
We may want to deprecate the option (i.e., render it useless) and mention its deprecation. Alternatively, we may just keep it. Who knows what compression schemes will be used in the future. |
I'm trying to build an appimage with xz compression due to AppImageLauncher not supporting zstd.
If i run appimagetool-x86_64.AppImage --comp xz .... , it will say "mksquashfs: Compressor "xz" is not supported!"
I believe it's becuase the bundled mksquashfs did not enable any compression methods other than zstd, making --comp meaningless
ref: ci/install-static-mksquashfs.sh
make -j"$jobs" GZIP_SUPPORT=0 XZ_SUPPORT=0 LZO_SUPPORT=0 LZ4_SUPPORT=0 ZSTD_SUPPORT=1 COMP_DEFAULT=zstd LDFLAGS=-static USE_PREBUILT_MANPAGES=y install
The text was updated successfully, but these errors were encountered: