Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --comp option in appimagetool #69

Open
pkwong4321 opened this issue Oct 7, 2024 · 6 comments
Open

Remove the --comp option in appimagetool #69

pkwong4321 opened this issue Oct 7, 2024 · 6 comments

Comments

@pkwong4321
Copy link

I'm trying to build an appimage with xz compression due to AppImageLauncher not supporting zstd.
If i run appimagetool-x86_64.AppImage --comp xz .... , it will say "mksquashfs: Compressor "xz" is not supported!"
I believe it's becuase the bundled mksquashfs did not enable any compression methods other than zstd, making --comp meaningless
ref: ci/install-static-mksquashfs.sh
make -j"$jobs" GZIP_SUPPORT=0 XZ_SUPPORT=0 LZO_SUPPORT=0 LZ4_SUPPORT=0 ZSTD_SUPPORT=1 COMP_DEFAULT=zstd LDFLAGS=-static USE_PREBUILT_MANPAGES=y install

@probonopd
Copy link
Member

probonopd commented Oct 7, 2024

Hi @pkwong4321, thanks for your comment. However, we are standardizing (no pun intended) on zstd.

So if you need AppImageLauncher, it might be a good idea to ask its developers to support zstd.

@pkwong4321
Copy link
Author

Just want to say the binary distributed here does not work with anything other than zstd, specified or not. If you want to standardize with zstd, you might want to remove the --comp option in appimagetool?

@probonopd
Copy link
Member

Yes, good idea. Thanks!

@probonopd probonopd reopened this Oct 8, 2024
@probonopd probonopd changed the title appimagetool.AppImage can only use zstd compression Remove the --comp option in appimagetool Oct 8, 2024
@Samueru-sama
Copy link
Contributor

Note that removing the --comp option will break workflows that are already using --comp zstd.

@probonopd
Copy link
Member

Good point...

@TheAssassin
Copy link
Member

We may want to deprecate the option (i.e., render it useless) and mention its deprecation. Alternatively, we may just keep it. Who knows what compression schemes will be used in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants