Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type2-runtime version/commit should be informed in stdout #80

Open
brunvonlope opened this issue Nov 30, 2024 · 4 comments
Open

type2-runtime version/commit should be informed in stdout #80

brunvonlope opened this issue Nov 30, 2024 · 4 comments

Comments

@brunvonlope
Copy link

When using appimagetool we know its version seeing the output:

appimagetool, continuous build (git version feac857), build 185 built on 2024-11-24 19:31:44 UTC

However, it don't give any clue about what "version" (commit sha) of the runtime will be used:

Downloading runtime file from https://github.com/AppImage/type2-runtime/releases/download/continuous/runtime-x86_64
Downloaded runtime binary of size 696720

Right now, developers need to rely on date and time of the creation of the appimage to get an estimative of what version/commit of the runtime is being used, which is imprecise. So, having this info in stdout would be very useful for debugging.

@TheAssassin
Copy link
Member

I'm not sure whether we include those data in the runtime in some portable way. Right now, we just don't have that information. Plus, continuous is a moving target anyway. We've always considered it stable, though. But if we come up with a nice way to transport the information, we can for sure display it in appimagetool.

In the future, we want to make actual releases of all components, then we can also, e.g., target the latest stable release.

@probonopd
Copy link
Member

probonopd commented Dec 2, 2024

After creating an AppImage, appimagetool could simply run --appimage-version on the resulting file and print out that information.

@brunvonlope in the meantime, your build script could of course simply do the same thing.

@TheAssassin
Copy link
Member

We should have an option to detect that information statically, i.e., without the need for a suitable runtime environment. An ARM runtime cannot be run on an AMD64 system, but the AppImage could be built normally.

@probonopd
Copy link
Member

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants