Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

appimaged recursion level/depth #14

Open
sandman7920 opened this issue Jun 17, 2018 · 5 comments
Open

appimaged recursion level/depth #14

sandman7920 opened this issue Jun 17, 2018 · 5 comments

Comments

@sandman7920
Copy link

I think it would be good if we were able to set recursion level.

I have several big libraries/frameworks in Applications folder (Android studio, android sdk, 4-5 versions of Qt, golang, etc), on start appimaged take a long time to check all the files.

@probonopd
Copy link
Member

Is it possible to do that using inotify?

@TheAssassin
Copy link
Member

@azubieta removed recursion from the AppImage search a while ago. See AppImage/AppImageKit#686.

@sandman7920
Copy link
Author

Recursion is still used on app start (at least with appimaged from this repo).

Tested with ./appimaged.AppImage -n -v

@TheAssassin TheAssassin reopened this Jun 17, 2018
@TheAssassin
Copy link
Member

You're right. We should fix this.

@TheAssassin
Copy link
Member

Relevant code: https://github.com/AppImage/appimaged/blob/master/src/main.c#L108
I guess it is sufficient to remove the recursive call in https://github.com/AppImage/appimaged/blob/master/src/main.c#L147.

@probonopd next time try using fts, it's faster and easier to use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants