Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header File Consitency #10

Open
lachlan194924 opened this issue Oct 15, 2024 · 5 comments
Open

Header File Consitency #10

lachlan194924 opened this issue Oct 15, 2024 · 5 comments

Comments

@lachlan194924
Copy link
Contributor

Using the script calculate_warehouse_stats.m, which is in actions, folder, all of the header files have been read and each row of the headerfile is a column in the Stats document, the purpose of this is to determine if there are synonyms in the document, we want consitant naming, despite meaning the same thing we only want to use one word.

image
the screenshot

For example in deployment information, Seafloor means the same as seabed, but for consistency we only want one of them to appear, This needs to be the case for every aspect of the header files, no blank spaces either.

warehouse_stats.xlsx
A summary pivot table can be found here^^

@lachlan194924
Copy link
Contributor Author

lachlan194924 commented Oct 22, 2024

I have created a big matlab structure to aid in the polishing of our headerfiles.
image
Each row in a header file is read in.

row 2 in this struct, tells you how many unique entries there are in the warehouse currently:
(This is agency name)
image

The first column shows you the uique name, the next is how many header files has it, then the next one is supposed to tell you the path of each header file that has it. BUT, right now it doesnt because i need to rerun the warehouse stats code to include that information but i dont have access right now.
So right now it tells you the Data tag, so at least you can try workout which codebase is responsable for producing that headerfile.
image

@lachlan194924
Copy link
Contributor Author

I have copied this code that I wrote on my laptop onto davy, it needs "calculate_warehouse_stats.m" to be run to get the filepath headers into the summary csv, then run "WarehouseStatSummary.m" to create the interactive structure, (this should have headerfiles in the struct because I added it I just cant test, due to no access). Alternatively my local copy produces with just the tag, and it works

@lachlan194924
Copy link
Contributor Author

This Script has just been ran on a full import (minus dwer) and The only issues atm are:

  1. Vertical datum for bomidy
  2. Program code, some caps some lowercase
  3. Deployment Postion
  4. Vertical reference

@lachlan194924
Copy link
Contributor Author

Deployment type of Integrated are not consistent with each other.

Deployment: Integrated
Deployment Position: 'Depth Range' OR 'Water Column'
Vertical Reference: 'Water Surface'

@lachlan194924
Copy link
Contributor Author

lachlan194924 commented Jan 17, 2025

  • Vertical Datum
  • Project
  • Deployment Position
  • Vertical Reference
  • Agency Names
  • Program
  • Station ID

Current Issues:

Vertical Datum:

Bom idy has a blank space,

  • can make it 'mAHD'

Image

Project

Most of the projects have similar naming structure however not all, will need external assistance to rename.
Image
Image

Deployment Position

Trying to use consistent phrasing. I would like to phase out the use of 'from' with either 'above' or 'below' ie X.Xm above Seabed instead of from seabed.
Also need to chat to Yvette or Relevent person about the other entries.

As mentioned above also the Integrated deployments need atteniton
Image

Theres some imos that do not have the correct deployment position, however the code has been updated. So potentially the code is not creating these anymore.

Image

Vertical Reference

Again just removing the use of from except for Datum. and keeping caps consistent.

Image

Agency Names

Uwa appears twice

Image

Program

WWMSP5 appears twice

Image

Station ID

wamsi 3 psd and sgrest

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant