[Feature request]: better error message when importing not well-formed conll files

[sylvainloiseau]

Is there already a feature request for this?

• I have searched the existing issues

Describe the problem to be solved

When importing an CONLL file in a projet, the parser may reject the file due to an error in the format.

For instance, a file containing the following sentence is rejected

# sent_id = 7
# text = soobaab
# text_en = 
# doc_id = 0
# doc_title = "bar"
# origin_s_id = 2.6
1              soobaab        _              _              _              _              _              _              _              _

With the message :

0.conll contains sentence with empty metadata value

Because the text_en sentence parameters was given no value.

In order to correct more easily such file, it would be great to have an indication of the line number of the issue, or the feature/sentence_id concerned.

Suggest a solution

No response

[B-CARON]

From my experience the information is given in the red flag. However it disappears too quickly to have time to read it properly. I had to copy and paste the message into an external editor to be able to use it. Le jeu. 15 févr. 2024, 13:56, sylvainloiseau ***@***.***> a écrit :

…

Is there already a feature request for this? - I have searched the existing issues Describe the problem to be solved When importing an CONLL file in a projet, the parser may reject the file due to an error in the format. For instance, a file containing the following sentence is rejected # sent_id = 7 # text = soobaab # text_en = # doc_id = 0 # doc_title = "bar" # origin_s_id = 2.6 1 soobaab _ _ _ _ _ _ _ _ With the message : 0.conll contains sentence with empty metadata value Because the text_en sentence parameters was given no value. In order to correct more easily such file, it would be great to have an indication of the line number of the issue, or the feature/sentence_id concerned. Suggest a solution *No response* — Reply to this email directly, view it on GitHub <#339>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYAZKWPOY6ZNQA7BRQPHGGTYTYAXVAVCNFSM6AAAAABDKGU4FCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTMNBVGY2DSMI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sylvainloiseau]

Yes another issue is that the red flag disappears to quickly, without the user being given the choice to discard it or not: it goes away automatically after some seconds. Moreover, it is on the top left of the screen (out of the focus of the user), and I have had to load several times my file before even noticing it. And my point was that it is to laconic: it could indicate the line of the problem in order for the user to correct the file. So a improvement, albeit not very crucial arguably, would be: - have the message in a « dialog » box, with a button « ok » for the the user to see it and to discard it when aknowledged; - have a more pieces of information included (the culprit feature ; its line number, if possible)

…

Le 15 févr. 2024 à 22:16, B-CARON ***@***.***> a écrit : From my experience the information is given in the red flag. However it disappears too quickly to have time to read it properly. I had to copy and paste the message into an external editor to be able to use it. Le jeu. 15 févr. 2024, 13:56, sylvainloiseau ***@***.***> a écrit : > Is there already a feature request for this? > > - I have searched the existing issues > > Describe the problem to be solved > > When importing an CONLL file in a projet, the parser may reject the file > due to an error in the format. > > For instance, a file containing the following sentence is rejected > > # sent_id = 7 > # text = soobaab > # text_en = > # doc_id = 0 > # doc_title = "bar" > # origin_s_id = 2.6 > 1 soobaab _ _ _ _ _ _ _ _ > > > With the message : > > 0.conll contains sentence with empty metadata value > > Because the text_en sentence parameters was given no value. > > In order to correct more easily such file, it would be great to have an > indication of the line number of the issue, or the feature/sentence_id > concerned. > Suggest a solution > > *No response* > > — > Reply to this email directly, view it on GitHub > <#339>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AYAZKWPOY6ZNQA7BRQPHGGTYTYAXVAVCNFSM6AAAAABDKGU4FCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTMNBVGY2DSMI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

----- Sylvain Loiseau ***@***.*** Université Sorbonne Paris Nord 99 avenue Jean-Baptiste Clément F-93430 Villetaneuse Laboratoire « Langues et civilisations à tradition orale » (UMR 7107 CNRS) Campus CNRS 7, rue Guy Môquet (bât. D) F-94801 Villejuif Cedex http://lacito.cnrs.fr

[khansadaoudi]

thanks for your feedbacks, your issue about the error messages that goes away quickly has been resolved

[B-CARON]

Following your recent change, the flags remain permanently, and become a problem for the annotation. It would be an improvement if we could we close them manually.

[khansadaoudi]

You can close it manually using the close button from the right

[B-CARON]

<!-- /* Font Definitions */ @font-face {font-family:"Cambria Math"; panose-1:2 4 5 3 5 4 6 3 2 4;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; font-size:11.0pt; font-family:"Calibri",sans-serif;} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} .MsoChpDefault {mso-style-type:export-only;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 70.85pt 70.85pt;} div.WordSection1 {page:WordSection1;} -->Thank you. I’ll have a better look. It was not visible on my screen.  Bernard CARON57, avenue d’Italie75013 PARIS06 63 68 15 19 De : Khensa Amani DaoudiEnvoyé le :lundi 19 février 2024 12:06À : Arborator/arborator-frontendCc : B-CARON; CommentObjet :Re: [Arborator/arborator-frontend] [Feature request]: better error message when importing not well-formed conll files (Issue #339) You can close it manually using the close button from the rightCapture.d.ecran.du.2024-02-19.12-05-16.png (view on web)—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>