Dds mode switch through external control #28696
Open
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
force-pushed
the
dds-mode-switch-through-external-control
branch
from
56d7c1e to
edc4819
Compare
|
@tizianofiorenzani - Can I get a review? |
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
dds-mode-switch-through-external-control
branch
from
48363bf to
2a177ab
Compare
tizianofiorenzani
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make mode switch go through external control so that we can disable it on a switch along with all the other DDS control interfaces.
Without this, misbehaving companion computer software on DDS may inadvertently fight for which mode the vehicle should be on with the operator that has the RC controller.
Details
Relates to https://github.com/ArduPilot/ardupilot/pull/28429/files