Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_ExternalControl: Only enable external control when DDS is enabled #28713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 23, 2024

Purpose

Only enable external control when it's needed by DDS. We don't want AP_ExternalControl taking up flash unless it's going to be called from an external interface.

Details

@Ryanf55 Ryanf55 added the ROS label Nov 23, 2024
@peterbarker
Copy link
Contributor

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeBlack                           *      *           -448    -392              -168   -304   *
CubeOrange-periph-heavy  *                                                                     
CubeOrangePlus                      *      *           -360    -400              -168   -288   *
CubeRedPrimary                      *      *           -376    -384              -168   -344   *
Durandal                            *      *           -400    -392              -168   -304   *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           -392    -376              -160   -288   *
MatekF405                           -24    *           -528    -584              -264   -384   -24
Pixhawk1-1M-bdshot                  -24                -576    -552              -272   -400   -24
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           -24    *           -584    -592              -272   -392   -24
skyviper-journey                                       -568                                    
skyviper-v2450                                         -472                                    

So... that's good....

Thanks!

@Ryanf55 Ryanf55 marked this pull request as ready for review November 23, 2024 14:48
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 23, 2024

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeBlack                           *      *           -448    -392              -168   -304   *
CubeOrange-periph-heavy  *                                                                     
CubeOrangePlus                      *      *           -360    -400              -168   -288   *
CubeRedPrimary                      *      *           -376    -384              -168   -344   *
Durandal                            *      *           -400    -392              -168   -304   *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           -392    -376              -160   -288   *
MatekF405                           -24    *           -528    -584              -264   -384   -24
Pixhawk1-1M-bdshot                  -24                -576    -552              -272   -400   -24
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           -24    *           -584    -592              -272   -392   -24
skyviper-journey                                       -568                                    
skyviper-v2450                                         -472                                    

So... that's good....

Thanks!

Yea, sorry about letting all this slip through the cracks earlier. This should resolve it:)

@Ryanf55 Ryanf55 requested a review from peterbarker November 23, 2024 14:50
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Dec 3, 2024

Blocked by #28651 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants