Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Logger: warn on high dropped log message rate #28737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andyp1per
Copy link
Collaborator

It's easy to miss this

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen logs that would just result in sending this message on every check at 1hz. I think it has to be rate limited down. Typically logging rates done change that much during flight, maybe just one warning per opend log is enough.

But do agree that it is often missed, it's a common bug report on filter review that the results look odd when really there is just no data to go on.

@andyp1per
Copy link
Collaborator Author

maybe just one warning per opend log is enough.

Tricky because there is usually a burst at startup which then settles down

@IamPete1
Copy link
Member

maybe just one warning per opend log is enough.

Tricky because there is usually a burst at startup which then settles down

@peterbarker has fixed that now, or at least on master I get 0 dropped messages. As you say we regularly got a few at log start before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants