Fix tab and space not working in WYSIWYG #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disclaimer: I translated this code back and forth from typescript. I have tested this on Legacy mode and it works, but these edits fix it for latest version. The code for legacy is essentially copied from current. Fixes... a whole bunch of issues. If I remember I'll edit and list them all, can't check right now. The way this works is by using `this.registerDomEvent` instead of CodeMirror edits. The key down event now also checks whether the current window is a markdown view, so you can't have accidental replaces in any other areas. If that's actually wanted, feel free to remove it (or make it a setting, although I haven't seen a place where the distinction would actually be relevant)
|
Tested and works for me, although I wonder if I've seen advanced tables use |
|
Oh yeah that'd definitely work too. I might try and do that but I'm quite busy atm so yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I translated this code back and forth from typescript.
I have tested this on Legacy mode and it works, but these edits fix it for latest version. The code for legacy is essentially copied from current.
Fixes #19, fixes #25 (maybe?), fixes #37 (maybe?), fixes #47 and fixes #52
The way this works is by using
this.registerDomEventinstead of CodeMirror edits. The key down event now also checks whether the current window is a markdown view, so you can't have accidental replaces in any other areas. If that's actually wanted, feel free to remove it (or make it a setting, although I haven't seen a place where the distinction would actually be relevant)