Fix calculation of foreground colours. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few things wrong here; firstly, the `color` of foreground text is not based on stacking all parent `color` attributes; it's based on stacking the single most specific `color` on top of all previous backgrounds. Secontly, int(0.9) is zero, so all semitransparency was being ignored.
|
…on further inspection, this does not fix the issue; despite modifying the maths as little as possible, it seems like the alpha channel is being interpreted backwards; I'm going to investigate this some more, and would encourage not merging this for the moment. |
This, in particular, fixes an issue where the 'span' in this html would
be considered to have a color of solid black:
<!doctype html>
<html>
<head>
<title>wcag zoo contrast testing</title>
<style>
span {
color: rgb(0, 0, 0);
}
div {
background-color: rgb(0, 0, 0);
color: rgb(255, 255, 255);
}
p span {
color: inherit;
}
</style>
</head>
<body>
<div>
<p><span>woof</span></p>
</div>
</body>
</html>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #16.
There were a few things wrong here; firstly, the
colorof foreground text is not based on stacking all parentcolorattributes; it's based on stacking the single most specificcoloron top of all previousbackgrounds.
Secontly, int(0.9) is zero, so all semitransparency was being ignored.