Skip to content
This repository has been archived by the owner on Dec 7, 2024. It is now read-only.

Chapter 03: The Game1 File #11

Closed
AristurtleDev opened this issue Oct 27, 2024 · 2 comments
Closed

Chapter 03: The Game1 File #11

AristurtleDev opened this issue Oct 27, 2024 · 2 comments

Comments

@AristurtleDev
Copy link
Owner

Chapter 03: The Game1 File Feedback

Please use this issue to discuss feedback specific to Chapter 03: The Game1 File

Feedback Guidelines

When providing feedback, please adhere to the following guidelines

  • Provide feedback relevant to the chapter as defined by the title of this issue.
  • For typos and grammatical errors, please provide them as a list with the line number they occur on. Do not separate them into individual feedback sections based on paragraphs
  • Use # headers where appropriate. Do not use them just to enlarge text
  • When correcting grammar, please ensure it is an actual grammar correction and not a personal opinion on how something should be written.
  • Inline with the above, suggestions on wording something better is encouraged, but please bear in mind that this tutorial is meant for developers who are already have a base understanding of C# as defined in the Preface documentation, and the tutorial is focused on teaching game development with MonoGame and not teaching C# programming.

Feedback Template

To make providing feedback easier, You can copy and paste the following template into your comment submission

## Chapter Feedback
<!-- provide feedback here related to the overall chapter.  Suggestions such as missing information, better explanations of topics, or removal of irrelevant content. -->

## Typos
<!-- provide a list here containing the line number and the typo made with a suggested correction -->
@titanix
Copy link

titanix commented Nov 23, 2024

First code block: the line if (GamePad.GetState(PlayerIndex.One).Buttons.Back == ButtonState.Pressed || Keyboard.GetState().IsKeyDown(Keys.Escape)) is long enough that it doesn't display totally on a 1800px wide resolution. I recommend using a new line so that there is not horizontal scroll bar.
In addition, I suggest using parenthesis after the condition, to teach the best practices to beginner.

if (GamePad.GetState(PlayerIndex.One).Buttons.Back == ButtonState.Pressed 
    || Keyboard.GetState().IsKeyDown(Keys.Escape))
{
    Exit();
}

Line 73: The first thing you'll notice [...] two instance member fields; a GraphicsDeviceManager ';' is probably a typo and should be changed to ','.

Personal opinion : When the base method is called, this is when the graphics device object is instantiated. => The graphics device object is instantiated when the base method is called.

Line 132: missing interrogation point at the end of line.

@AristurtleDev
Copy link
Owner Author

@titanix Thanks for the feedback, I forgot to update this repository to mention that everything is now moved into a draft PR with the actual documentation repository at MonoGame/docs.monogame.github.io#85

As each chapter is written, it is put as a PR in my fork at https://github.com/AristurtleDev/docs.monogame.github.io/tree/2d-tutorial-bounty where I post for feedback from community and final approval from MonoGame foundation before merging that chapter into the draft PR.

Future feedback should be left in these places.

Again i apologize for the confusion and lack of me updating this repository since moving to the new system. I will have an update on the bounty issue in the MonGame repo soon to explain this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants