Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Auto-Instrumentation for OpenAI should be Disabled Off for Auto-Instrumentation for Langchain/Llamaindex #4070

Open
jlopatec opened this issue Jul 30, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request instrumentation openinference instrumentations to various open-source projects python Pull requests that update Python code stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Comments

@jlopatec
Copy link
Collaborator

We have a lot of instrumentations that use both Auto-Instrumentor for LangChain / Llama and OpenAI. I would like the OpenAI Auto Instrumentor to detect if its running in LangChain / LlamaIndex files. If so disable.

Possibly you could do this by using "inspect" library / looking if we called from LangChain file in frame.filename
# Check if the function is called from a specific file
for frame in inspect.stack():
filename = frame.filename

@jlopatec jlopatec added enhancement New feature or request triage issues that need triage labels Jul 30, 2024
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Jul 30, 2024
@mikeldking
Copy link
Contributor

Thanks Jason for the feedback. We have some ideas about making instrumentation composable but langchain itself is currently very difficult. Going to leave this parked here for now.

@mikeldking mikeldking added instrumentation openinference instrumentations to various open-source projects python Pull requests that update Python code and removed triage issues that need triage labels Jul 30, 2024
@harrisonchu harrisonchu self-assigned this Aug 29, 2024
Copy link

dosubot bot commented Dec 28, 2024

Hi, @jlopatec. I'm Dosu, and I'm helping the Arize Phoenix team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Enhancement proposal to disable OpenAI Auto Instrumentor within LangChain or LlamaIndex files.
  • Suggestion to use the "inspect" library to check the call stack for LangChain file calls.
  • @mikeldking acknowledged the feedback but noted challenges with LangChain and left the issue unresolved.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the Arize Phoenix repository. If so, you can keep the discussion open by commenting on the issue.
  • If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request instrumentation openinference instrumentations to various open-source projects python Pull requests that update Python code stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
Status: 📘 Todo
Development

No branches or pull requests

3 participants