We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The variable explanation_template miss a default None value if it is not assigned.
explanation_template
None
To Reproduce Steps to reproduce the behavior:
from phoenix.evals.templates import ClassificationTemplate
rails = ["correct", "incorrect"] prompt_template = "prompt template ..... " template = ClassificationTemplate( template= prompt_template, rails=rails )
AttributeError: 'ClassificationTemplate' object has no attribute 'explanation_template'
If the explanation_template attribute is filled, no error occurs:
rails = ["correct", "incorrect"] prompt_template = "prompt template ..... " template = ClassificationTemplate( template= prompt_template, rails=rails, explanation_template="Explaination: " )
Expected behavior Because the attribute is not mandatory, the class should handle the missing value.
Screenshots Error occurs in the red rectangle because the attribute has not been set in the yellow one.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered:
@Sprizgola thanks for the catch. I think your right that it shouldn't be required if explanations are turned off. Will get the team to take a look.
Sorry, something went wrong.
hi @Sprizgola thanks for finding this! The fix for this can be tracked here: #5877 and should be released soon.
anticorrelator
Successfully merging a pull request may close this issue.
Describe the bug
The variable
explanation_template
miss a defaultNone
value if it is not assigned.To Reproduce
Steps to reproduce the behavior:
from phoenix.evals.templates import ClassificationTemplate
explanation_template
:AttributeError: 'ClassificationTemplate' object has no attribute 'explanation_template'
If the
explanation_template
attribute is filled, no error occurs:Expected behavior
Because the attribute is not mandatory, the class should handle the missing value.
Screenshots
Error occurs in the red rectangle because the attribute has not been set in the yellow one.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: