Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coerce to string when output.value is not None (e.g. bool) #5892

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: coerce to string when output.value is not None (e.g. bool) #5892

merged 1 commit into from
Jan 3, 2025

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Jan 3, 2025 •
edited
Loading

resolves #5891

Screenshot 2025-01-03 at 1 29 41 PM Screenshot 2025-01-03 at 1 29 35 PM Screenshot 2025-01-03 at 1 32 58 PM

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 3, 2025
@manuel-delverme
Copy link

fixes #5891

@RogerHYang RogerHYang merged commit 5c7e6d3 into main Jan 3, 2025
58 checks passed
@RogerHYang RogerHYang deleted the fix-output-value-bool branch January 3, 2025 21:42
@mikeldking mikeldking mentioned this pull request Jan 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] span.set_attribute(OUTPUT_VALUE, True)
3 participants
@RogerHYang @manuel-delverme @mikeldking