Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator character is not escaped #27

Open
lordlothar99 opened this issue Aug 2, 2024 · 2 comments
Open

Separator character is not escaped #27

lordlothar99 opened this issue Aug 2, 2024 · 2 comments

Comments

@lordlothar99
Copy link

if the resultset contains the separator character "), then the output is messed up

lordlothar99 pushed a commit to lordlothar99/oqlmodule that referenced this issue Aug 2, 2024
lordlothar99 pushed a commit to lordlothar99/oqlmodule that referenced this issue Aug 6, 2024
lordlothar99 pushed a commit to lordlothar99/oqlmodule that referenced this issue Aug 6, 2024
lordlothar99 pushed a commit to lordlothar99/oqlmodule that referenced this issue Aug 6, 2024
lordlothar99 pushed a commit to lordlothar99/oqlmodule that referenced this issue Aug 6, 2024
@ArjenLammers
Copy link
Owner

ArjenLammers commented Aug 6, 2024

hi @lordlothar99 can you be bit more prescriptive what looks messed up when?
your change ends up having both the same quote char as escape char which doesn't look correct to me (for the download)

@lordlothar99
Copy link
Author

sure @ArjenLammers ; sorry for not explaining properly
when a column contains a JSON string (containing fields with double quotes) :

  • when the data is displayed in the app : everything is fine
  • when the data is exported as a CSV file : the encoding is wrong (the double quotes are not backed by a second double quote)

my update impacts only the download option

ArjenLammers added a commit that referenced this issue Aug 7, 2024
Separator character is not escaped #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants