Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print file with '#' in name #892

Open
sharpner opened this issue Jul 31, 2024 · 2 comments
Open

Print file with '#' in name #892

sharpner opened this issue Jul 31, 2024 · 2 comments
Labels
not moonraker reported issue with other software

Comments

@sharpner
Copy link

What happened

Uploading a file with # in the filename works, but it does not get a preview image, see the difference between the files:

image

Trying to print it anyways results in:
image

After some testing I figured out that when the filename of the gcode contains the # special character, it won't work.

Client

Mainsail

Browser

Safari

How to reproduce

Upload a gcode file with # in the name. Can by via web interface or directly onto the host (I did it via samba share) does not matter.

Additional information

mainsail
v2.12.0
moonraker
v0.9.2-0-gb40751ba

@sharpner sharpner added the bug Something isn't working label Jul 31, 2024
@Arksine Arksine added not moonraker reported issue with other software and removed bug Something isn't working labels Jul 31, 2024
@Arksine
Copy link
Owner

Arksine commented Jul 31, 2024

Hi. It appears you have two different issues, however I don't believe that either is specific to a bug in Moonraker.

With regard to the missing image, I can only speculate without a log, but I suspect the frontend is not properly escaping the # when requesting the image.

The larger issue, which likely makes the image problem moot, is that Klipper cannot accept a # as part of a gcode command parameter. Thus, when Moonraker attempts to run SDCARD_PRINT_FILE FILENAME=..., you get the malformed command error.

@sharpner
Copy link
Author

Hey, thanks for the answer!

Makes sense, I would already be happy if the frontend would let me know that # is not allowed when uploading an image - took me too long to find the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not moonraker reported issue with other software
Projects
None yet
Development

No branches or pull requests

2 participants