Not saving selected map style

[russellshome]

When that selected map type is changed, that change is not saved.

The incorrect code is in our.umbraco.gmaps.controller.js
Starts with switch ($scope.mapType)

Upper case first letter is incorrect so 'Hybrid' should be 'hybrid' etc.

[ronaldbarendse]

Thanks for reporting @russellshome 👍 Getting or setting the map type shouldn't depend on casing differences, so this is indeed something that needs fixing!

Seems like Google uses all-lowercase and these values can also be retrieved from the google.maps.MapTypeId object using the uppercase variants (e.g. google.maps.MapTypeId.HYBRID):

I've already added an obsolete message to the C# property, so this will probably be rewritten for version 2 of this package:

Our.Umbraco.GMaps/src/Our.Umbraco.GMaps.Core/Models/GMapsMapConfig.cs

Lines 22 to 43 in 081fad4

	[JsonProperty("maptype")]
	[Obsolete("This property should not return a different value than previously set.")]
	public string MapType
	{
	get
	{
	switch (this._mapType)
	{
	case "Hybrid":
	return "google.maps.MapTypeId.HYBRID";
	case "Satellite":
	return "google.maps.MapTypeId.SATELLITE";
	case "Terrain":
	return "google.maps.MapTypeId.TERRAIN";
	case "styled_map":
	return "styled_map";
	default:
	return "google.maps.MapTypeId.ROADMAP";
	}
	}
	set => this._mapType = value;
	}

[bjarnef]

I noticed when you have entered a custom mapstyle JSON it is not possible to delete/clear this again.
After saving datatype instance it is loading the original mapstyle JSON.

Tested on v1.3.3 and Umbraco v8.9.0

[robertjf]

Hi all, can someone confirm whether this is still an issue in the current version for me.

Otherwise, this issue will be closed in a couple of weeks...