Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Google Maps Library #176

Open
abdulhade opened this issue Sep 10, 2024 · 11 comments
Open

Deprecated Google Maps Library #176

abdulhade opened this issue Sep 10, 2024 · 11 comments

Comments

@abdulhade
Copy link

abdulhade commented Sep 10, 2024

Dear owner,

I hope you are doing well.

Could you help me please?

The warning bellow does my map not showing:

js?key=XXXXX&callback=XXXX.locationMap:200 As of February 21st, 2024, google.maps.Marker is deprecated. Please use google.maps.marker.AdvancedMarkerElement instead. At this time, google.maps.Marker is not scheduled to be discontinued, but google.maps.marker.AdvancedMarkerElement is recommended over google.maps.Marker. While google.maps.Marker will continue to receive bug fixes for any major regressions, existing bugs in google.maps.Marker will not be addressed. At least 12 months notice will be given before support is discontinued. Please see https://developers.google.com/maps/deprecations for additional details and https://developers.google.com/maps/documentation/javascript/advanced-markers/migration for the migration guide.

@robertjf
Copy link
Collaborator

@abdulhade is this on your front end implementation or in the Umbraco BackOffice?

@abdulhade
Copy link
Author

Hi @robertjf it is implemented on my frontend.

@robertjf
Copy link
Collaborator

Ok, then you will need to review the Google documentation according to that error - we can assist with implementations of the plugin in the umbraco backoffice, but the front end is outside of our scope...

@abdulhade
Copy link
Author

abdulhade commented Sep 10, 2024

Sorry @robertjf . I don't understand why I need to review. It is your library whose responsable to render the google maps on my frontend.

Maybe, I didn't explain myself correctly.

I installed your plugin in my backoffice umbraco, I created datatypes that is using your Property Editor.

And then I implement this property on my documentType that renders on my frontend.

@robertjf
Copy link
Collaborator

@abdulhade we don't render the frontend for you, we only provide the map properties for you to use when rendering the map yourself. We render the map in the Umbraco BackOffice.

@abdulhade
Copy link
Author

Hi @robertjf , I checked this error on BackOffice now and it is showing the same error.

@robertjf
Copy link
Collaborator

ok, can you please add some details to the error in the BackOffice - Dev Console logs, errors, etc.

@abdulhade
Copy link
Author

Hi, @robertjf ,

I'm sorry, what kind of detail do you need? It is the same error. Do you need a print screen, like this?
image

js?key=XXXXX&libraries=places&callback=googleMapsInitialized:671 As of February 21st, 2024, google.maps.Marker is deprecated. Please use google.maps.marker.AdvancedMarkerElement instead. At this time, google.maps.Marker is not scheduled to be discontinued, but google.maps.marker.AdvancedMarkerElement is recommended over google.maps.Marker. While google.maps.Marker will continue to receive bug fixes for any major regressions, existing bugs in google.maps.Marker will not be addressed. At least 12 months notice will be given before support is discontinued. Please see https://developers.google.com/maps/deprecations for additional details and https://developers.google.com/maps/documentation/javascript/advanced-markers/migration for the migration guide.

@robertjf
Copy link
Collaborator

robertjf commented Sep 11, 2024

@abdulhade can you tell me:

  • What Umbraco Version are you using:
  • What version of Our.Umbraco.GMaps are you using:

It also looks like you don't have the Google Maps API key registered correctly, which would be more the real reason the maps aren't displaying. The deprecation warnings about google.maps.Marker are just informational at this stage.

Take a look at the actual JavaScript API error messages.

@abdulhade
Copy link
Author

Hi @robertjf

Version of Our.Umbraco.GMap:

  • 1.2.0 with Umbraco 8.18.14;
  • 3.0.2 with Umbraco 13.4.1.

About the Google Maps API Key, I did it because I can't show you this information.

Best regards,
Abdul Abbas

@JasonElkin
Copy link

JasonElkin commented Sep 25, 2024

I've just come across this same warning.

It is an issue in the Backoffice, here's a screengrab from an Umbraco v13.5 site, with GMaps v3.0.2 installed:
image

Everything still works fine, and it looks like there's no plan to remove the feature just yet - but it the warning has been flagged by one of our clients following a regression test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants