-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi marker feature in a single map #27
Comments
@pasangtamang Rewriting this package to properly support multiple markers will require quite some work, so feel free to share the things you've already done by creating a PR. The current editor is also explicitly named Our.Umbraco.GMaps/src/Our.Umbraco.GMaps/App_Plugins/Our.Umbraco.GMaps/package.manifest Line 5 in 41786eb
Our.Umbraco.GMaps/src/Our.Umbraco.GMaps.Core/PropertyValueConverter/GMapsPropertyValueConverter.cs Line 13 in 41786eb
To prevent breaking changes, the multiple marker editor can be created as a completely different editor or would otherwise require at least the following:
Because of all the complexities involved with this, I would recommend just adding this editor within a Nested Content/Block List and have every marker stored separately and render it in a single map on the front-end. |
@ronaldbarendse My implementation I have done as a separate data type. So existing single picker will still remain same as it was. I will add a PR so you can see the changes. |
@pasangtamang are you still interested in contributing your enhancements to the package? We've recently upgraded to support both Umbraco 8 & 9 and I'd be very interested to see your changes and how we can incorporate them... |
@robertjf It's been a long time I made changes as per few of my project requirement. I will check my repo and refresh myself. Then I will get back to you on this topic before end of this week. |
@pasangtamang that'd be great if you could :) Would be a great addition to version 2.0.2 - even if you could get the html and controller changes that'd be a great start :) |
@robertjf I did a look into my code and found that due to new structural change in this package, I have to do some bug fixing. This will take me few more days. With the older version it works fine. If you want to check before my bug fixing in newer version then you can check in branch v1.3.2 from my repository (https://github.com/pasangtamang/Our.Umbraco.GMaps/tree/v1.3.2). There is one thing you will notice quickly. In backoffice you will find all the marker not showing at once. It switched only after you click on edit button. |
thanks @pasangtamang - I'll take a look and see how I can adapt it... Ta |
Recently we were in need of adding multiple location. As a solution we were in need of option to add multi marker from in Google map plugin. We extended the feature from original package and now we would like to make this available for community. Below you can see how the UI is
Next step is create a PR to merge with the plugin?
The text was updated successfully, but these errors were encountered: