Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Throwable serialization #40

Open
BrandonArp opened this issue May 11, 2016 · 2 comments
Open

Improve Throwable serialization #40

BrandonArp opened this issue May 11, 2016 · 2 comments

Comments

@BrandonArp
Copy link
Member

When serializing throwables, a naive approach is used. Instead, use the same mechanisms that are used to serialize other objects.
@vjkoskela
Copy link
Member

Addressed in #42

BrandonArp pushed a commit that referenced this issue May 18, 2016
@vjkoskela @BrandonArp
Address Issue: Improve Throwable Serialization (#40) (#42)
eae9d61 
* Extend exception serialization to include all data fields in the same manner as standard data and context objects.

* Fixed unit tests.
@vjkoskela
Copy link
Member

This was only partially addressed in #42. Although exception data in the exception block is serialized in a way to be consistent with data serialization for additional fields, this does not apply to exceptions in the data block. That is exceptions in the data block do not serialize as Steno exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrandonArp @vjkoskela