Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement comparison on UnknownFieldSet #33

Open
LyndonGingerich opened this issue Aug 16, 2023 · 2 comments
Open

Implement comparison on UnknownFieldSet #33

LyndonGingerich opened this issue Aug 16, 2023 · 2 comments

Comments

@LyndonGingerich
Copy link

LyndonGingerich commented Aug 16, 2023 •
edited
Loading

I would like to be able to use Set operations on my generated message types, but this requires comparison. Could we implement comparison on UnknownFieldSet so F# can use structural comparison?
@LyndonGingerich
Copy link
Author

This would probably resolve #30.

@LyndonGingerich LyndonGingerich changed the title Implement equality and comparison Implement comparison on UnknownFieldSet Aug 16, 2023
@LyndonGingerich
Copy link
Author

I also thought of implementing custom comparison that doesn't consider UnknownFields, but then comparing two items might return 0 when equality (which does consider UnknownFields) says they're not equal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LyndonGingerich