-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐FEAT: Footer icons dont support dark/light mode. #215
Comments
Hi Arsalan, I would like to work on this issue, pls assign this to me. |
@AniketSaraswat112 Sure thing, Assigned to you. Dont forger to star this repo. |
Looks pretty neat. Id love to see some other ideas as well. Some hover effects or some good color combos with the theme. Do your thing. |
Hi @ArslanYM, made a few changes, and attaching the video, please review these. Starter.Hive.-.Google.Chrome.2023-06-07.01-13-19.mp4I have tried the same colors as the page theme. |
Looks great @AniketSaraswat112 . However, Can we keep the icon colors default for dark mode , and add better colors for light mode. Also the animation is not necessary at this point. |
Hi @ArslanYM I have kept the default color for dark theme, for light mode I thought of using neon colors for the icons as attached below: I have used the below color scheme: Also we can have the black theme for light mode. |
Looks sick, Would love to the video, Take a screen recording. |
Yeah sure below are the two recordings of the colors that I propose, I also thought of some animation that will look good added them in the first recording while the second one is without animation as you suggested. Starter.Hive.-.Google.Chrome.2023-06-10.10-07-24.mp4Starter.Hive.-.Google.Chrome.2023-06-10.10-09-14.mp4 |
@AniketSaraswat112 why havent you raised a PR yet? |
Hi, @ArslanYM you haven't confirmed the changes, I proposed two changes in my previous reply, please confirm which one should I go ahead with and then I'll create a PR. |
Go for the first one, but the color for light mode must be changed. |
TODO:
The text was updated successfully, but these errors were encountered: