Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐FEAT: Footer icons dont support dark/light mode. #215

Open
ArslanYM opened this issue Jun 5, 2023 · 12 comments
Open

⭐FEAT: Footer icons dont support dark/light mode. #215

ArslanYM opened this issue Jun 5, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request FRONTEND This requires changes in the Frontend good first issue Good for newcomers

Comments

@ArslanYM
Copy link
Owner

ArslanYM commented Jun 5, 2023

TODO:

  • Add different default color for footer icons.
  • Dynamic for dark/light mode.
    footer
@ArslanYM ArslanYM added enhancement New feature or request good first issue Good for newcomers FRONTEND This requires changes in the Frontend labels Jun 5, 2023
@AniketSaraswat112
Copy link

Hi Arsalan, I would like to work on this issue, pls assign this to me.

@ArslanYM
Copy link
Owner Author

ArslanYM commented Jun 5, 2023

@AniketSaraswat112 Sure thing, Assigned to you. Dont forger to star this repo.

@AniketSaraswat112
Copy link

HI ArslanYM, I was thinking to go with #23272A color on light theme and with "white" on dark theme, Attaching the screenshots of both, please review and confirm whether I should go with these colors.

Light Theme :

image

Dark Theme:

image

@ArslanYM
Copy link
Owner Author

ArslanYM commented Jun 5, 2023

HI ArslanYM, I was thinking to go with #23272A color on light theme and with "white" on dark theme, Attaching the screenshots of both, please review and confirm whether I should go with these colors.

Light Theme :

image

Dark Theme:

image

Looks pretty neat. Id love to see some other ideas as well. Some hover effects or some good color combos with the theme. Do your thing.

@AniketSaraswat112
Copy link

AniketSaraswat112 commented Jun 6, 2023

Hi @ArslanYM, made a few changes, and attaching the video, please review these.

Starter.Hive.-.Google.Chrome.2023-06-07.01-13-19.mp4

I have tried the same colors as the page theme.

@ArslanYM
Copy link
Owner Author

ArslanYM commented Jun 7, 2023

Looks great @AniketSaraswat112 . However, Can we keep the icon colors default for dark mode , and add better colors for light mode. Also the animation is not necessary at this point.

@AniketSaraswat112
Copy link

AniketSaraswat112 commented Jun 9, 2023

Hi @ArslanYM I have kept the default color for dark theme, for light mode I thought of using neon colors for the icons as attached below:
image
twitterIcon: #D875FF
githubIcon: #6b5c5c
discordIcon: #8D4BE0

I have used the below color scheme:
image

Also we can have the black theme for light mode.
Please review this.

@ArslanYM
Copy link
Owner Author

ArslanYM commented Jun 9, 2023

Looks sick, Would love to the video, Take a screen recording.

@AniketSaraswat112
Copy link

Looks sick, Would love to the video, Take a screen recording.

Yeah sure below are the two recordings of the colors that I propose, I also thought of some animation that will look good added them in the first recording while the second one is without animation as you suggested.
Please let me know which colors should I apply with light theme while I have kept the default colors for dark theme, and whether I should keep the animation or remove it:

Starter.Hive.-.Google.Chrome.2023-06-10.10-07-24.mp4
Starter.Hive.-.Google.Chrome.2023-06-10.10-09-14.mp4

@ArslanYM
Copy link
Owner Author

@AniketSaraswat112 why havent you raised a PR yet?

@AniketSaraswat112
Copy link

Hi, @ArslanYM you haven't confirmed the changes, I proposed two changes in my previous reply, please confirm which one should I go ahead with and then I'll create a PR.

@ArslanYM
Copy link
Owner Author

Go for the first one, but the color for light mode must be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FRONTEND This requires changes in the Frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants