Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing isTitle by the users wont work with the latest version #7

Open
wojtek-krysiak opened this issue Dec 24, 2019 · 2 comments
Open

Comments

@wojtek-krysiak
Copy link
Contributor

it is about this line of code:

f4958d1#diff-a0fd37dbd71a46e75c8117ce125dea23R35

In original BaseRecord "title" is taken from the ResourceDecorator because it (ResourceDecorator) takes into consideration what users are setting in AdminBroOptions, and in particular isTitle property: https://softwarebrothers.github.io/admin-bro-dev/PropertyOptions.html#isTitle

so now when users change "isTitle" in PropertyOptions it won't affect the system.

We should leave it as it was (taken from the ResourceDecorator)

BTW - I was thinking about creating a slack account for AdminBro - would you like to join it?

@Arteha
Copy link
Owner

Arteha commented Dec 25, 2019

I am for joining. good idea.

@Arteha
Copy link
Owner

Arteha commented Dec 25, 2019

But this line is just for fancy text in Dropdowns and clickable relations. Like in Django .__str__().
f4958d1#diff-a0fd37dbd71a46e75c8117ce125dea23R35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants