Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Blurhash using Image's Aspect Ratio #667

Closed
1 task done
Arthi-chaud opened this issue Jun 18, 2024 · 0 comments · Fixed by #754
Closed
1 task done

Compute Blurhash using Image's Aspect Ratio #667

Arthi-chaud opened this issue Jun 18, 2024 · 0 comments · Fixed by #754
Assignees
Labels
Enhancement/Optimization Anything that could be managed better
Milestone

Comments

@Arthi-chaud
Copy link
Owner

Arthi-chaud commented Jun 18, 2024

The number of color on each axis is arbitrarily set to 4, whatever the source image's aspect ratio is.
For album covers (1:1), it is not a problem. However, for video thumbnails, the blurhash looks stretched, and thus not good.

  • When computing an image's blurhash, the number of color per axis should depend on the image's aspect ratio
    • Examples: for a 16:9 image, we could have 4 on the X-axis, and 2 on the Y axis, 4:3 => 4 on the X-axis, 3 on the Y-axis
@Arthi-chaud Arthi-chaud added the Enhancement/Optimization Anything that could be managed better label Jun 18, 2024
@Arthi-chaud Arthi-chaud added this to the v3.0.0 milestone Jun 18, 2024
@Arthi-chaud Arthi-chaud self-assigned this Jun 18, 2024
@Arthi-chaud Arthi-chaud mentioned this issue Sep 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement/Optimization Anything that could be managed better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant