Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOI task setup #73

Open
javiferran opened this issue Jul 3, 2023 · 2 comments · May be fixed by #76
Open

IOI task setup #73

javiferran opened this issue Jul 3, 2023 · 2 comments · May be fixed by #76

Comments

@javiferran
Copy link

Hi! Very nice work, and thanks for sharing the code.
In the paper you mention that, for the IOI experiment, you did not split the computational graph into the query, key and value
calculations for each head (Appendix E). I see the default behavior is to consider them split, and I was wondering if there is a straightforward way to modify it so that I can reproduce your results. Setting tl_model.set_use_split_qkv_input(False) makes assertion in verify_model_setup() flag.

Thanks in advance.

Javier

@ArthurConmy ArthurConmy linked a pull request Jul 8, 2023 that will close this issue
@ArthurConmy
Copy link
Owner

ArthurConmy commented Jul 8, 2023

Hey @javiferran , thanks for reaching out!

See #76 . Hopefully TransformerLens will allow the changes soon!

I have some runs on at the moment and the different seed seems to mean my results look a bit better with a slightly lower threshold (e.g 0.04... here https://api.wandb.ai/links/remix_school-of-rock/asj1u03n ).

EDIT: I also believe that in the paper the figure used the remove_redundant flag which deletes nodes that don't have any important incoming connections. This leads to better looking output graphs but which often miss e.g negative heads

@javiferran
Copy link
Author

Hi @ArthurConmy! Thanks a lot for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants