Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 Window dimming logic is inverted #975

Open
myblindy opened this issue Dec 25, 2024 · 2 comments
Open

5.0.0 Window dimming logic is inverted #975

myblindy opened this issue Dec 25, 2024 · 2 comments

Comments

@myblindy
Copy link

myblindy commented Dec 25, 2024

This is the case in at least the vcpkg release. This code here is the problem:

Element DefaultRenderState(const WindowRenderState& state) {
  Element element = state.inner;
  if (state.active) {
    element |= dim;
  }

The current git code is correct, it dims on inactive, not on active. I'll make a patch for the vcpkg port for myself, but I'm reporting this in case you want to release a fixed version as well.

@ArthurSonzogni
Copy link
Owner

Thanks!

I think we are going to release v6.0.0 soon, but I am not ready yet. We might want to create a branch and merge every non breaking changes.

@myblindy
Copy link
Author

For what it's worth, I also had to patch in your menu changes (and all of the base component changes due to that), the 5.0.0 menu doesn't pick up mouse clicks inside a window component, the window eats them instead.

With the changes, it's fully functional now though!

Repository owner deleted a comment Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants