Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A release zip for the Homebrew distribution #17

Open
mhavo opened this issue Dec 22, 2017 · 5 comments
Open

A release zip for the Homebrew distribution #17

mhavo opened this issue Dec 22, 2017 · 5 comments

Comments

@mhavo
Copy link

mhavo commented Dec 22, 2017

On mac environment the Homebrew and it's extension Caskroom/homebrew-fonts would provide easy installation of URW-fonts, if there is a release zip available like this font has: https://github.com/rsms/inter/releases

https://brew.sh/
https://caskroom.github.io/
https://github.com/caskroom/homebrew-fonts/blob/master/CONTRIBUTING.md

@deekej
Copy link
Contributor

deekej commented Dec 22, 2017

I'm not sure I understand what you are asking for. The fonts are already available as a zip release:
https://github.com/ArtifexSoftware/urw-base35-fonts/releases

Either I'm missing your point, or you're asking for something that already exists...

@mhavo
Copy link
Author

mhavo commented Dec 22, 2017

I am asking for you to make a release so that it meets naming requirements. Look that contributing doc or what needs to be in the cask:

https://github.com/caskroom/homebrew-fonts/blob/c622857e8df75ce33eeeef47393ba400339764c7/Casks/font-inter-ui.rb

Basically the name of the zip file needs to be urw-base35-fonts-{version}.zip

@deekej
Copy link
Contributor

deekej commented Jan 2, 2018

Well, right now it's named like it. If you download it from here:
https://github.com/ArtifexSoftware/urw-base35-fonts/archive/20170801.zip

if you download it from that link, the resulting filename will be this:
urw-base35-fonts-20170801.zip, which is the same you're requesting (urw-base35-fonts-{version}.zip)

In my understanding of how things work here at Github, you're basically asking for the resulting archive to be named like this (after download):
urw-base35-fonts-urw-base35-fonts-20170801.zip

That does not make much sense to me. And looking at

https://github.com/caskroom/homebrew-fonts/blob/c622857e8df75ce33eeeef47393ba400339764c7/Casks/font-inter-ui.rb

I guess that you could simply update the url in that specification to use the link stated above correctly. (Correct me if I'm wrong.)

I would much rather see you changing the url in your package specification rather than doing it here globally, because there are at least 3 Linux distributions that I'm aware of, which already use existing URLs/naming scheme. Changing the URLs/naming scheme according to your request would break the automatic building process on those distributions.

@mhavo
Copy link
Author

mhavo commented Jan 3, 2018

I think I misunderstood some naming schemes in Brew. This set is now implemented there also and everything is fine. Sorry for the any inconvenience...

@alerque
Copy link

alerque commented Mar 1, 2020

I think this issue can be closed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants