Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create error summary component #15

Open
Asad-acc opened this issue Mar 10, 2023 · 1 comment
Open

Create error summary component #15

Asad-acc opened this issue Mar 10, 2023 · 1 comment
Assignees
Labels
needs testing This needs testing new component New component needs to be built

Comments

@Asad-acc
Copy link
Owner

No description provided.

@Asad-acc Asad-acc added the new component New component needs to be built label Mar 10, 2023
@Asad-acc Asad-acc self-assigned this Mar 10, 2023
@Asad-acc Asad-acc added the needs testing This needs testing label Mar 10, 2023
@Tosin-Balogun
Copy link

This is superb work! I have tested all the variants of it and it all works well.

The spacing between elements are correct (16px mobile, 24px desktop), even when adding new error messages on the toggle.

The hover, active states are on point as well.

It looks comprehensive.

The issue that remains seem to be the default dimensions which I can see at the moment is set to 309px for mobile and 694px for desktop.

I plan to look into the common device dimensions of visitors who come to our website and see if this can help steer our thinking. I suspect it is between 375/320 for mobile and 1080/1440 for desktop as these are the ones I have seen in past data crunches I have done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing This needs testing new component New component needs to be built
Projects
Status: Needs Testing
Development

No branches or pull requests

2 participants