Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create details component #6

Open
Asad-acc opened this issue Mar 10, 2023 · 2 comments
Open

Create details component #6

Asad-acc opened this issue Mar 10, 2023 · 2 comments
Assignees
@Asad-acc
Labels
new component New component needs to be built

Comments

@Asad-acc
Copy link
Owner

No description provided.

@Asad-acc Asad-acc added the new component New component needs to be built label Mar 10, 2023
@Asad-acc Asad-acc self-assigned this Apr 4, 2023
@Tosin-Balogun
Copy link

So, similar to the previous ones, the pattern here seem to be the consideration for mobile width.

Currently, it goes beyond the common sizes for mobile

Image

@Tosin-Balogun
Copy link

On desktop, the component bits all seem solid, from basic details to behaviour states. I could not investigate the spacing, but I can see the 24px bottom has been factored into the overall height so looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Asad-acc Asad-acc

Labels
new component New component needs to be built
Projects
Design System Figma Roadmap
Status: Needs Testing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tosin-Balogun @Asad-acc