-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defunct link in README and clarification about libsignal #1522
Comments
The directory for upstream libsignal-service-java inside Signal-Android has changed, I just updated the link in the README. Thanks for the hint. The upstream libsignal-service-java ist just a module in Signal-Android. I'm using a script to get the changes from there and add them to the patched libsignal-service-java fork. The fork repository also has an upstream branch (https://github.com/Turasa/libsignal-service-java/tree/upstream) which just contains the copied unpatched upstream libsignal-service, with just some additional build files. libsignal is a lower level library, that's used internally by the libsignal-service module. |
Thanks a lot for a prompt reply and explanation. : ) |
Just to double check. So before 2022 Signal had one big library for Android called libsignal-service-java but now they split it to libsignal-service with Android/Java specif code and platform-agnostic APIs of libsignal which is used by And |
Yes. Signal created libsignal to share code between their different platforms and then replaced the corresponding code in libsignal-service. |
In
README.md
the link to location of libsignal-service-java inside Signal-Android source code now results in404 - page not found
.Related question, could you clarify the situation with the
libsignal-service-java
?The official Signal's repository has been archived since Feb 12, 2022 and has been replaced by libsignal it seems.
README.md
mentions thatsignal-cli
uses patched libsignal-service-java and this @Turasa 's repository is still updated.But when Signal official
libsignal-service-java
where do you get updates for it? Could @AsamK or somebody else who knows it clarify this?Given lack of information it raises question of how and for how long can
signal-cli
catch up to official Signal development - when it fact everything might be just fine and only theREADME.md
is outdated. : )The text was updated successfully, but these errors were encountered: