Double Ripple

[jt-gilkeson]

In the sample app, if you choose MODE_SHIFTING and BS_STATIC, the first time you select items they sometimes show a double ripple effect (one ripple for the "entire shifted area" (large), and one for the "tab item" (small)). The second time you select the same tab it no longer has the double ripple. (i.e. select tab 2 (double ripple sometimes), select other tabs, select tab 2 (always "tab item ripple")).

Once you have MODE_SHIFTING and BS_STATIC, you can make it happen over and over if you simply click on the 5 items checkmark (to force a re-initialize) and then select other tabs.

Another thing that's interesting - changing tab does a "tab item ripple" (small), while clciking the already selected tab does a "entire shifted area ripple" (larger). The "double ripple" looks like ripples get created for both areas (small and large ripple happen at the same time).

[Ashok-Varma]

@jt-gilkeson can you add a video i can't exactly understand the issue.

[jt-gilkeson]

http://tinypic.com/r/icmut5/9

The first and the last time in the video when I press the "Books" tab it does the double ripple. The last "Books" click it's really visible.

By the way, what tool did you use to make your gif screen captures for the front page readme?

[Ashok-Varma]

By double ripple you mean big ripple. I will check it out.

@jt-gilkeson in used Android tool(https://github.com/mortenjust/androidtool-mac) to record the video and then converted video to GIF using (http://ezgif.com/video-to-gif).

[jt-gilkeson]

Thank you for the info.

I updated the original comment with a little more info about the two types of ripples I see (tab - small) (shift area - larger). The double ripple looks like both areas draw the ripple at the same time (small and larger simultaneously). Like I said it only seems to happen (sometimes - it's not consistent) the first time you click on each tab after re-initializing - once a tab item has been selected at least once after re-initializing, it wont do the double ripple again.

In the video - I'm forcing a re-init by clicking the 5 items checkbox after each series of tab clicks.

To see the two sizes I'm referring to:
Small ripple = ripple size when selecting a new tab
Big Ripple = ripple size you click the already selected item.

Normally in MODE_SHIFTING and BS_STATIC:

When you select a new tab it does the Small Ripple, when you click on an already selected tab you see the Big Ripple. The bug I'm seeing is after re-initializing (via selecting 5 items checkbox or any other item that forces a re-init), you will sometimes see both ripples drawn when you select a new tab (instead of just the normal small ripple for a new tab selection).

[Ashok-Varma]

@jt-gilkeson i think i might have the reason why is that happening. i will check and let you know by night

[Ashok-Varma]

@jt-gilkeson i can't reproduce this bug. I think this is default behaviour which are mentioning. Can you retest it.

If you tap on it and hold you can see double ripple and if you just tap it single ripple will be shown. this is default behaviour. I can't observe any change when i re-initialise and after selecting each tab at-least once.

[jt-gilkeson]

This is different than the tap and hold scenario - when you tap and hold a new tab you will see a ripple fill the the small area slowly (yes you see two shades of the ripple, one that fades in and one that ripples out - but they are in the same size area) - that is normal behavior. If you tap and hold an already selected tab, you will the ripple fill a large area slowly (fade in and ripple out) - again normal behavior. The bug is if you re-initialize if you tap a new tab (without holding) you will sometimes (not often - it's rare) see both a small ripple and a large ripple simultaneously appear (both ripple out, but to different sized areas) - if you hold, only the small ripple appears, because while you are holding the view doesn't shift to the larger area yet.

If you look at the video closely - the first time and last time I click "Books" (start of the video and end of the video) you will see the large ripple (both the small and larger ripple are animated - which may be hard to see, but it's easy to see the large ripple) get animated - that should never happen on a first click of a tab - whether doing a tap and release or a tap and hold, it should only be animating the small ripple.

Not a big bug - it's hard to reproduce, but may indicate that something is not being cleared correctly when the re-initialize takes place.

[Ashok-Varma]

@jt-gilkeson Ok. i was not able to reproduce, sorry for bothering too much. But can you just write the pattern to reproduce something like

start app -> click on 1 -> click on 2 -> ....etc -> reinitialise (click 5 items)-> click 1-> click 2 (here you can see the bug) -> click 3 -> reinitialise -> click 4 (again you can see bug)

where tabs range is 1,2,3,4,5.

[jt-gilkeson]

What you've described is pretty much accurate. It's hard to reproduce but that is the key, just keep reinitializing and selecting new tabs. It may be easier to see in landscape mode.