Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepanshutr/chore #436

Merged
merged 21 commits into from
Apr 24, 2024
Merged

Deepanshutr/chore #436

merged 21 commits into from
Apr 24, 2024

Conversation

deepanshutr
Copy link
Member

No description provided.

Updated the Help function in auxiliary_keeper.go to handle invalid requests and null properties. Specifically, the request is now being type-checked and validated, and properties in the request are being checked for null before proceeding with further processing.
The removed lines in the test file for auxiliary_request included assertions that were not necessary for the purpose of the test. This change simplifies the test and focuses it only on validating the auxiliary request functionality.
…ryRequest.Validate() and implemented custom validation. The validation now iterates over all properties in the PropertyList. Redundant function auxiliaryRequestFromInterface has been removed.
@github-actions github-actions bot added the test label Apr 24, 2024
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
44.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member Author

@deepanshutr deepanshutr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reviewed

@deepanshutr deepanshutr merged commit 13da4d4 into master Apr 24, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant