mint tk test cases fix v1 #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deepanshutr
requested changes
Aug 5, 2024
| @@ -22,7 +22,7 @@ require ( | |||
| google.golang.org/grpc v1.62.1 | |||
| ) | |||
|
|
|||
| //replace github.com/AssetMantle/schema => ../schema | |||
| replace github.com/AssetMantle/schema => ../schema | |||
| @@ -209,7 +209,6 @@ git.sr.ht/~sircmpwn/getopt v0.0.0-20191230200459-23622cc906b3/go.mod h1:wMEGFFFN | |||
| git.sr.ht/~sircmpwn/go-bare v0.0.0-20210406120253-ab86bc2846d9/go.mod h1:BVJwbDfVjCjoFiKrhkei6NdGcZYpkDkdyCdg1ukytRA= | |||
| github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 h1:/vQbFIOMbk2FiG/kXiLl8BRyzTWDw7gX/Hz7Dd5eDMs= | |||
| github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4/go.mod h1:hN7oaIRCjzsZ2dE+yG5k+rsdt3qcwykqK6HVGcKwsw4= | |||
| github.com/AssetMantle/schema v0.0.0-20240206102051-27352b802163/go.mod h1:SindcyQCFIEKPOp4mNrnegXrJ2uwQfq3D1r+G93Gz3Q= | |||
| conformAuxiliary helpers.Auxiliary | ||
| mintAuxiliary helpers.Auxiliary | ||
| ) | ||
| // start |
| ParamsKeeper := paramsKeeper.NewKeeper( | ||
| var _ helpers.AuxiliaryKeeper = (*MockAuxiliaryKeeper)(nil) | ||
|
|
||
| func (mockAuxiliaryKeeper *MockAuxiliaryKeeper) Help(context context.Context, request helpers.AuxiliaryRequest) (helpers.AuxiliaryResponse, error) { |
There was a problem hiding this comment.
parameter name can be refactored to keep in sync with other files
| args := mockAuxiliaryKeeper.Called(context, request) | ||
| return args.Get(0).(helpers.AuxiliaryResponse), args.Error(1) | ||
| } | ||
| func (mockAuxiliaryKeeper *MockAuxiliaryKeeper) Initialize(m2 helpers.Mapper, manager helpers.ParameterManager, i []interface{}) helpers.Keeper { |
There was a problem hiding this comment.
parameter name can be refactored to keep in sync with other files
| toID: baseIDs.PrototypeIdentityID(), | ||
| classificationID: baseIDs.PrototypeClassificationID(), | ||
| immutableProps: baseLists.NewPropertyList(), | ||
| mutableProps: baseLists.NewPropertyList(baseProperties.NewMetaProperty(baseIDs.NewStringID("prop1"), baseData.NewNumberData(sdkTypes.NewInt(1)))), |
| return | ||
|
|
||
| tt.setup(t) | ||
| //fmt.Print(tt.args.classificationID) |
There was a problem hiding this comment.
should not commit commented code
|
|
||
| var _ helpers.AuxiliaryKeeper = (*MockAuxiliaryKeeper)(nil) | ||
|
|
||
| func (mockAuxiliaryKeeper *MockAuxiliaryKeeper) Help(context context.Context, request helpers.AuxiliaryRequest) (helpers.AuxiliaryResponse, error) { |
There was a problem hiding this comment.
parameter names should follow cb conventions
| }{ | ||
| {"+ve", fields{Mapper, authenticateAuxiliary, maintainAuxiliary, conformAuxiliary}, args{Mapper, parameterManager, []interface{}{}}, transactionKeeper{Mapper, authenticateAuxiliary, maintainAuxiliary, conformAuxiliary}}, | ||
| {"mutateValidAsset", |
| _ = supplementAuxiliaryKeeper.On("Help", mock.Anything, mock.Anything).Return(new(helpers.AuxiliaryResponse), nil) | ||
| _ = supplementAuxiliaryKeeper.On("Help", mock.Anything, supplement.NewAuxiliaryRequest(supplementAuxiliaryFailureAsset.GetProperty(constantProperties.LockHeightProperty.GetID()))).Return(supplement.NewAuxiliaryResponse(baseLists.NewPropertyList()), errorConstants.MockError) | ||
|
|
||
| mesaLockAsset = randomAssetGenerator(baseProperties.NewMesaProperty(constantProperties.LockHeightProperty.GetKey(), baseData.NewHeightData(baseTypes.NewHeight(1))), nil) |
There was a problem hiding this comment.
can more randomAssetGenerator to simulation utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any
relevant follow-up issues.
I have...
in the PR title
!to the type prefix if API or client breaking changesee PR Targeting)
for building modules
integration tests
CHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items
reviewed if you only reviewed selected items.
I have...
correct type prefix in the PR title
!in the type prefix if API or client breaking change