(Online) tests should use ScopeSim_Data

[hugobuddel]

The tests should include ScopeSim_Data, at least when ran online on github, but perhaps not by default when ran locally.

The nightly download_data run of ScopeSim_Data should be the only automated github job than fetches data from third parties like ESO. This has a double purpose: testing whether those third party services work, and creating a PR with any new data that is needed for new tests/notebooks.

However, that ScopeSim_Data job effectively does a pip install -e "ScopeSim[test,dev,docs]", so we cannot simply add ScopeSim_Data to the test dependencies of ScopeSim, since then the nightly download_data run would not actually download anything.

Skycalc is currently broken, see https://jira.eso.org/browse/PIPE-11264 , and the only tests that seem to fail are the ScopeSim notebook tests. For now I will add pip install git+https://github.com/AstarVienna/ScopeSim_Data.git to notebooks_dispatch.yml so I won't get any emails during the Feiertage.

We can discuss a better solution later.