-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scopesim.Source fails with cube filename input and tabular WCS #499
Comments
I thought I had specifically addressed TAB WCS cubes in my source fields change. Obviously not very well, at least for this case. I'll take a look (probably tomorrow), I should know where to look for this... |
I think I remember that it works if you open the file first and then pass the HDUL instead, but can't check now. Feel free to try that 🙂 |
Hang on, I actually did that in this notebook! Which branch are you on for the IRDB? |
I guess I haven't used the latest version of the notebook. That sounds a bit hacky, though. |
Yeah I agree that filename should also work (again). I think I made this change after the whole source fields stuff broke it and this was easier than going back there. But I should implement a proper fix, it shouldn't be that hard... |
Looking at the current implementation, when My suggestion to properly solve this:
|
Addendum: It is possible to load a TAB WCS from another HDU even with a certain |
This is from the example notebook
LSS_AGN-01_preparation.ipynb
inirdb/METIS
, using scopesim 0.9.0a6:Obviously,
self.field
has lost theWCS-TAB
extension that is in the fits file. I don't know whatself.from_hdul
is, would that help?The text was updated successfully, but these errors were encountered: