Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lms detector ordering #516

Open
AGlasse opened this issue Dec 10, 2024 · 5 comments
Open

lms detector ordering #516

AGlasse opened this issue Dec 10, 2024 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@AGlasse
Copy link

AGlasse commented Dec 10, 2024

Dear ScopeSim,
It appears that the LMS detector numbering (from 1 to 4) is ordered in a clockwise direction, rather than left to right. This may cause complications in the pipeline since the wavelength scale within each detector and for the boresight wavelengths of det 1 to 2 all run left to right, but the boresight wavelengths in dets 3 and 4 are flipped. Is this a feature? If it is I'd be grateful to know why you do it this way,
Thanks,
..Alistair

@oczoske
Copy link
Collaborator

oczoske commented Dec 10, 2024

Hi Alistair,
I did it that way because I didn't know any better (I think the numbering is the standard numbering of quadrants in mathematics). In fact, I still cannot find the official layout in the document (I checked version 3 of E-REP-ATC-MET-1003, but may have missed it). Can you provide that, please? Is it just a matter exchanging numbers 3 and 4? For reference, the layout is defined in the file FPA_metis_lms_layout.dat in the METIS instrument package (so really an irdb issue), and this is a good time to bring that up to date. The current layout reads

id  x_cen    y_cen     x_size  y_size  pixel_size  angle   gain
 1  +19.547  +19.547   2048    2048    0.018       0.0     1.0
 2  -19.547  +19.547   2048    2048    0.018       0.0     1.0
 3  -19.547  -19.547   2048    2048    0.018       0.0     1.0
 4  +19.547  -19.547   2048    2048    0.018       0.0     1.0

(coordinate values in mm in the focal plane). Should any of the detectors be rotated or flipped? The gain value obviously needs to be changed (in a development branch I've already set it to 2, which I think is typical for HxRGs).

@AGlasse
Copy link
Author

AGlasse commented Dec 10, 2024 via email

@hugobuddel
Copy link
Collaborator

A small thing to note is that the pipeline should work irrespective of the ordering of the extensions in the FITS files, because it is not (formally) guaranteed that the Instrument Control Software always writes out the extensions in the same order (although in practice this is the case). The extensions should have headers identifying which is which, so we should identify what these keywords are and what values they should have for the LMS detector.

Alistair, it seems that if you reply be email, that then the text of the issue shows up on the issue tracker (as intended), but any attachment is apparently lost. Could you please attach your working draft to the issue at #516 manually?

@AGlasse AGlasse closed this as completed Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in ScopeSim-development Dec 11, 2024
@teutoburg teutoburg added the question Further information is requested label Dec 11, 2024
@hugobuddel
Copy link
Collaborator

Reopened because closed accidentally

@hugobuddel hugobuddel reopened this Dec 12, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in ScopeSim-development Dec 12, 2024
@oczoske
Copy link
Collaborator

oczoske commented Dec 12, 2024

So is there anything that needs to be done about this issue? Note that the numbering of the detectors has nothing to do with the implementation of the EFP-to-MFP transforms, which has always followed the description in E-REP-ATC-MET-1016 and is, I believe, quite similar if not identical to the current draft. Scopesim first computes the (noiseless) MFP (called ImagePlane in Scopesim) and only then sticks in the detectors and reads out. The detector labeling is really quite arbitrary and at this point we only care about where they are in the MFP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: 🏗 In progress
Development

No branches or pull requests

4 participants