Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use or remove zombie classes #566

Open
teutoburg opened this issue Feb 12, 2025 · 1 comment
Open

Use or remove zombie classes #566

teutoburg opened this issue Feb 12, 2025 · 1 comment
Assignees
Labels
refactor Implementation improvement

Comments

@teutoburg
Copy link
Contributor

teutoburg commented Feb 12, 2025

The class PoorMansHeader appears to be used only in MonochromeTraceCurve, which itself is never used anywhere except in unit tests for itself.

@astronomyk what was the original intention of MonochromeTraceCurve? Is it a zombie from SimCADO (or SpecCADO or whatever) days? Do we have any use for it? If not, I suggest removing it.

In the case of PoorMansHeader, there might be other points to consider, see the attached sub-issue.

@teutoburg teutoburg added the refactor Implementation improvement label Feb 12, 2025
@teutoburg teutoburg self-assigned this Feb 12, 2025
@teutoburg teutoburg moved this from 🆕 New to 📋 Backlog in ScopeSim-development Feb 12, 2025
@teutoburg
Copy link
Contributor Author

Same goes for spectrograph.py, which is an empty module. The existence of it has recently also caused confusion with at least one user that I know of.

Same also for fov_utils.make_flux_table(), fov_utils.combine_table_fields(), fov_utils.combine_imagehdu_fields() (except in a comment somewhere), fov_utils.sky2fp(), fov_utils.extract_common_field(), fov_utils.make_cube_from_table(), all of which seem to be completely unused except in their own unittests. Find out if there's any use case for these functions (perhaps in the context of something like MOS or the issue of "bright source just outside the FOV" etc.) or whether they're truly redundant and their functionality is done by other code, in which case they should be removed.

This also applies to all functions in fov_manager_utils.py!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation improvement
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant