Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code for AsteroidOSSync/pull/216 #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+192 −72
Open

Adjust code for AsteroidOSSync/pull/216 #1

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ba4762
Modify tap2ble for the libslirp-based implementation
I-asked Apr 30, 2024
c0ad151
Update documentation to reflet the libslirp changes
I-asked Apr 30, 2024
c168eac
Clean up CMakeLists.txt
I-asked Apr 30, 2024
c48a6f4
Use correct MTU
I-asked May 2, 2024
8dad96b
Make sure connman is started before tap2ble
I-asked May 2, 2024
7a45626
Update documentation
I-asked May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ble.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,6 @@ void BLE::onReceivedFromCompanion(const QByteArray &content) {
void BLE::onMtuChanged(int mtu) {
if (mCurrentMtu != mtu) {
mCurrentMtu = mtu;
emit mtuChanged(mtu);
emit mtuChanged(mtu - 3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the origin of this constant ? And extract it into a named macro maybe ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And squash thsi into the code that introduced it :)

}
}