Use systemd instead of upstart #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat :) it would be good to get rid of that abstraction! I see your implementation differs quite a lot from the sailfishos "platform code" to interact with systemd. It looks to me like the two code should do pretty much exactly the same thing. Have you considered using the same code for both ? I feel we could remove the platform abstraction entirely and just have one class for both. Maybe there's a subtle detail I'm missing in which case they could have very slight variations within the same file. Maybe I'm missing something big and then it's justified to keep two implementations. |
|
I have tried to use the sailfish os code. If I remember correctly, some part was different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is mentioned in AsteroidOS/telescope#63 ubuntu 20.04 focal is using systemd instead of upstart.
In fact, big part of code can be shared with SailfishOS platfrom.