Angular pack: no template highlighting

[osenvosem]

Installed the Angular pack but angular templates is still highlighted as simple html files.

Has anyone it working?

[kmiasko]

It's probably mismatch of ABI between angularjs treesitter and newer neovim.

nvim-treesitter/nvim-treesitter-angular#2

You need to build tree sitter plugin manually from fork posted in that issue.

[osenvosem]

It's probably mismatch of ABI between angularjs treesitter and newer neovim.

I think in this case I would see the corresponding error in checkhealth. There is no error.

If it is necessary to build something manually, why do I need this pack?) In this case the fork should be part of the pack.

[Uzaaft]

It's probably mismatch of ABI between angularjs treesitter and newer neovim.

I think in this case I would see the corresponding error in checkhealth. There is no error.

If it is necessary to build something manually, why do I need this pack?) In this case the fork should be part of the pack.

Feel free to create a PR then, if you think this fork should be part of the pack. :)

[Uzaaft]

Do any of you guys use https://github.com/joeveiga/ng.nvim ? Experiences?

[Uzaaft]

It's probably mismatch of ABI between angularjs treesitter and newer neovim.

I think in this case I would see the corresponding error in checkhealth. There is no error.

If it is necessary to build something manually, why do I need this pack?) In this case the fork should be part of the pack.

Re this:
The packs tries to solve the initial setup for new users by providing a starting point and an easy to setup solution. Alas, we can't compensate for the bad state of angular TS stuff.

[Uzaaft]

Going ahead and closing this due to inactivity.

[osenvosem]

Re this:
The packs tries to solve the initial setup for new users by providing a starting point and an easy to setup solution. Alas, we can't compensate for the bad state of angular TS stuff.

There is a working fork you could use in this pack nvim-treesitter/nvim-treesitter-angular#3

Going ahead and closing this due to inactivity.

While the problem isn't solved.

[Uzaaft]

Re this:
The packs tries to solve the initial setup for new users by providing a starting point and an easy to setup solution. Alas, we can't compensate for the bad state of angular TS stuff.

There is a working fork you could use in this pack nvim-treesitter/nvim-treesitter-angular#3

Going ahead and closing this due to inactivity.

While the problem isn't solved.

Due to inactivtiy.
An I'm not sure which fix you're refering to by linking that issue...A link to the comment fixing the issue would be more helpfull.

[osenvosem]

An I'm not sure which fix you're refering to by linking that issue...A link to the comment fixing the issue would be more helpfull.

use({ "elgiano/nvim-treesitter-angular", branch = "topic/jsx-fix" })

[Uzaaft]

Please check the code in the pack. :)

[osenvosem]

Please check the code in the pack. :)

Yep, but it still doesn't work while people in the issue stated that it does for them. Don't know why... 🫤

[Uzaaft]

Please check the code in the pack. :)

Yep, but it still doesn't work while people in the issue stated that it does for them. Don't know why... 🫤

And people are also saying that it DIDN't fix the issue, so 🤷🏾‍♂️

[osenvosem]

Please check the code in the pack. :)

Yep, but it still doesn't work while people in the issue stated that it does for them. Don't know why... 🫤

And people are also saying that it DIDN't fix the issue, so 🤷🏾‍♂️

It didn't fixed the issue with inline templates.

Here I found the fork with regenerated parser, it should fix the issue with incorrect ABI version https://github.com/ShooTeX/tree-sitter-angular/tree/main

[Uzaaft]

We'll have to check to see if there are any other issues with that fork. I'll re-open the issue

[osenvosem]

We'll have to check to see if there are any other issues with that fork. I'll re-open the issue

Thank you.

[osenvosem]

@Uzaaft cloned repos and applied fixes to each. Could you please try if it's working?

https://github.com/osenvosem/tree-sitter-angular
https://github.com/osenvosem/nvim-treesitter-angular

[Uzaaft]

@kmiasko Would you be up to testing @osenvosem fix. I myself don't use angular

[Theaninova]

Doesn't seem to fix everything for me, the Angular thing says it's working but TypeScript is still broken.

The following errors have been detected: ~
- ERROR typescript(injections): ...ed-0.9.4/share/nvim/runtime/lua/vim/treesitter/query.lua:259: query: invalid node type at position 7470 for language typescript
  typescript(injections) is concatenated from the following files:
  |    [OK]:"/nix/store/7m3zm75rdg8bfk17wvjysrd5s361a5h7-vim-pack-dir/pack/myNeovimPackages/start/nvim-treesitter/queries/ecma/injections.scm"
  |    [OK]:"/nix/store/7m3zm75rdg8bfk17wvjysrd5s361a5h7-vim-pack-dir/pack/myNeovimPackages/start/nvim-treesitter/queries/ecma/injections.scm"
  | [ERROR]:"/nix/store/7m3zm75rdg8bfk17wvjysrd5s361a5h7-vim-pack-dir/pack/myNeovimPackages/start/nvim-treesitter/queries/jsx/injections.scm", failed to load: ...ed-0.9.4/share/nvim/runtime/lua/vim/treesitter/query.lua:259: query: invalid node type at position 26 for language typescript
  |    [OK]:"/nix/store/7m3zm75rdg8bfk17wvjysrd5s361a5h7-vim-pack-dir/pack/myNeovimPackages/start/nvim-treesitter/queries/javascript/injections.scm"
  |    [OK]:"/nix/store/7m3zm75rdg8bfk17wvjysrd5s361a5h7-vim-pack-dir/pack/myNeovimPackages/start/nvim-treesitter/queries/typescript/injections.scm"

[osenvosem]

The Angular parser has been merged into the nvim-treesitter.

nvim-treesitter/nvim-treesitter@1e74c34