Marked channel local variable as final (#2042)

prat · prat · commit 66806a412247 · 2025-05-09T23:05:47.000+05:30
diff --git a/client/src/main/java/org/asynchttpclient/netty/NettyResponseFuture.java b/client/src/main/java/org/asynchttpclient/netty/NettyResponseFuture.java
@@ -187,7 +187,7 @@ public boolean cancel(boolean force) {
             return false;
         }
 
-        Channel ch = channel; //atomic read, so that it won't end up in TOCTOU
+        final Channel ch = channel; //atomic read, so that it won't end up in TOCTOU
         if (ch != null) {
             Channels.setDiscard(ch);
             Channels.silentlyCloseChannel(ch);

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ public boolean cancel(boolean force) {`
`187`	`187`	`return false;`
`188`	`188`	`}`
`189`	`189`
`190`		`- Channel ch = channel; //atomic read, so that it won't end up in TOCTOU`
	`190`	`+ final Channel ch = channel; //atomic read, so that it won't end up in TOCTOU`
`191`	`191`	`if (ch != null) {`
`192`	`192`	`Channels.setDiscard(ch);`
`193`	`193`	`Channels.silentlyCloseChannel(ch);`