Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure Number Issue in 14-1.md #461

Open
marofmar opened this issue Aug 20, 2020 · 10 comments
Open

Figure Number Issue in 14-1.md #461

marofmar opened this issue Aug 20, 2020 · 10 comments

Comments

@marofmar
Copy link
Contributor

Hi, there is inconsistency in the name of the figure and how it is indicated in the following explanation.

For example, in figure 5 case, it is actively used to describe the content but it is called figure 19 in the explanation. As the figure itself contains the number, it makes sense, but this hinders a smooth understanding of the lecture note.

I think there are two solutions to this:

  1. Remove figure name part in the figure picture itself or
  2. Change figure name in the explanation

<center>
<img src="{{site.baseurl}}/images/week14/14-1/Fig5.png" style="background-color:#DCDCDC;" /><br>
Figure 5.
</center>

A simple example of a factor graph is shown in Figure 19 (top). The energy function is the sum of four factors:






<center>
<img src="{{site.baseurl}}/images/week14/14-1/Fig6.png" style="background-color:#DCDCDC;" /><br>
Figure 6.
</center>

The factor graph shown in Figure 20 is a log domain factor graph for linear structured models ("simple energy-based factor graphs" we are talking about)

@marcozullich
Copy link
Contributor

I would also add that figures might need captioning as in all of the other documents.
Would you be so kind as to add captioning to the EN version of 14-1?

@Atcold
Copy link
Owner

Atcold commented Oct 16, 2020

@marofmar, thanks for pointing this out.
Can you convert the bitmap caption in textual caption? In this way we can translate it to other languages as well.
Moreover, could you add captions to all the other figures as well?

Thanks!

@marcozullich
Copy link
Contributor

Btw, since I hadn't got an answer to my first reply, I've already started putting captions while I'm translating the Italian version, in case @marofmar won't answer.

@marofmar
Copy link
Contributor Author

Hi @marcozullich, sorry that I checked your reply so late,
@marcozullich @Atcold noted!! I will add captions to all the other figures in [EN]14-1.md

marofmar added a commit to marofmar/pytorch-Deep-Learning that referenced this issue Oct 18, 2020
Figure Number Issue in 14-1.md 
Atcold#461

Figure 5 -> Figure 19, Figure 6 -> Figure 20
So, the figure numbering goes like 4->19->20->7 and so forth.
Please enlighten me if I misunderstood your comments! @Atcold
@marofmar
Copy link
Contributor Author

@Atcold bitmap caption which is included in the bitmap image is already used in the textual caption to explain the content. I modified a bit for consistency, but it results in messy ordering in the numbering system in figures of 14-1.md.

I think modifying the bitmap image itself, cropping it out the bitmap caption in the image, would be a better option. Anyhow please check that out on the github.io webpage and the PR of mine.

@Atcold
Copy link
Owner

Atcold commented Nov 12, 2020

Yes, we should crop the images, put the caption in written form, and update the references to the figure number to reflect the correct numbering.

@marofmar
Copy link
Contributor Author

As the PR of mine on Oct 17 has not been merged yet, and won't be, I think cropping the images would be the only work that left! @marcozullich @Atcold

@marofmar
Copy link
Contributor Author

oh I just checked the note again, and will make a quick fix and PR again, thanks @marcozullich !

marofmar added a commit to marofmar/pytorch-Deep-Learning that referenced this issue Nov 27, 2020
@Atcold
Copy link
Owner

Atcold commented Dec 11, 2020

Thanks! Getting to it right now!

Atcold pushed a commit that referenced this issue Dec 11, 2020
t46 pushed a commit to t46/pytorch-Deep-Learning that referenced this issue Dec 17, 2020
Atcold added a commit that referenced this issue Dec 18, 2020
* add week07 drafts

* Update 07-1.md

* Update 07-2.md

* Update 07-3.md

* Update 07.md

* Update _config.yml

* japanese translation week11

* japanese translation week11

* add week7

* add week07 & week11

* add week11 & week14

* add week12

* add week13

* add week06

* add week09

* add week10

* modify week14

* add week02

* add week01

* add week03

* add week08 (Jesmer Wong)

* review and modify week01

* add week02/02.md

* review and modify week02

* Update 03-2.md

* Update 03-3.md

* Update 06-1.md

* Update 06-2.md

* Update 06-3.md

* Update 06.md

* Update 07-2.md

* Update 07.md

* Update 09-1.md

* Update 09-3.md

* Update 09.md

* Update 10-1.md

* Update 10-2.md

* Update 10-3.md

* Update 10.md

* Update 11.md

* Update 12-1.md

* Update 12-2.md

* Update 12-3.md

* Update 12.md

* Update 13-1.md

* Update 13-2.md

* Update 13-3.md

* Update 13.md

* Update 14-1.md

* Update 14-2.md

* Update 14-3.md

* Update 14.md

* Update 11-3.md

* Update 11-2.md

* Update 11-1.md

* Update _config.yml

* review and modify week03

* review and modify week04

* [VI] Translation of README.md, index.md, 01.md (#579)

* index.md

* README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update index.md

* Create Lecture01.md

* Rename Lecture01.md to Lecture01.sbv

* Create Slide01.md

* Update and rename Slide01.md to 01.md

* Update index.md

* Create Lecture01.sbv

* Create 01.md

* Delete 01.md

* Delete Lecture01.sbv

* Update 01.md

* Update index.md

* Update README-VI.md

* Update and rename 01.md to ch01.md

* Update README-VI.md

* Update index.md

* Update index.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update and rename ch01.md to 01.md

* Update index.md

* Update README-VI.md

* Update README-VI.md

* Update README-VI.md

* Update index.md

* Update index.md

* Update 01.md

* Update index.md

* Update index.md

* Create 01-1.md

* Update 01-1.md

* Update 01-1.md

* Update 01-1.md

* Update 01-1.md

* Update index.md

* Update index.md

* Update 01-1.md

* Update 01-1.md

* Update 01.md

* Update index.md

* Update 01-1.md

* Update 01-1.md

* Update 01-1.md

* Add Vietnamese flag

* All-caps title

* Rename docs/vi/week01/01.md to docs/vi/Tuần 01/01.md

* Update 01.md

* Rename docs/vi/week01/01-1.md to docs/vi/Tuần 01/01-1.md

* Rename docs/vi/week01/Lecture01.sbv to docs/vi/Tuần 01/Lecture01.sbv

* Update index.md

* Update index.md

* Update _config.yml

* Update 01-1.md

* Update 01-1.md

* Create 01-2.md

* Update 01-2.md

* Update 01-2.md

* Rename docs/vi/Tuần 01/01.md to docs/vi/Week01/01.md

* Rename docs/vi/Tuần 01/01-1.md to docs/vi/Week01/01-1.md

* Rename docs/vi/Tuần 01/01-2.md to docs/vi/Week01/01-2.md

* Rename docs/vi/Tuần 01/Lecture01.sbv to docs/vi/Week01/Lecture01.sbv

* Create 01-3.md

* Update 01-3.md

* Update 01-3.md

* Update 01-3.md

* Update 01-3.md

* Update 01-3.md

* Create practicum01.sbv

* Rename Lecture01.sbv to lecture01.sbv

* Delete lecture01.sbv

* Delete practicum01.sbv

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

* Update index.md

Co-authored-by: Alfredo Canziani <[email protected]>

* Fix Vietnamese contribution

* I had added Vietnam Translating Contents into README.md (#695)

* Update README.md

* Update README.md

* Update README-AR.md

* Update README-ES.md

* Update README-FA.md

* Update README-FR.md

* Update README-IT.md

* Update README-JA.md

* Update README-JA.md

* Update README-KO.md

* Update README-RU.md

* Update README-TR.md

* Update README-ZH.md

* Update README-AR.md

* Update README-ES.md

* Update README-FA.md

* Update README-FR.md

* Update README-IT.md

Co-authored-by: Alfredo Canziani <[email protected]>

* Fix fucking typo

* [ZH] Fixing some issue on 13-2 (#698)

Issues:
I forgot to comment out some English words.
The "[基準化分析法圖形神經網絡](https://arxiv.org/pdf/2003.00982.pdf/)" shows the code rather than the link and words.
I see ### and ** often do not work in Chinese. I will see what we will have after this pull request.

* [ZH] Fixing the latex issue 13-3 (#697)

* [ZH] Fixing the latex issue

* Update 13-3.md

* Update 13-3.md

* Update 13-3.md

* [SR] Translation of README (#672)

* added initial readme

* added translation of readme

* added switch to Serbian language

* added translation of index.md

* updated sr to srb

* updated srb to rs

* Update and rename README-SR.md to README-RS.md

* Rename docs/sr/README-RS.md to docs/rs/README-RS.md

* Rename docs/sr/index.md to docs/rs/index.md

* updated representation learning translation

* resolved comments on pr

* Update and rename docs/rs/README-RS.md to docs/sr/README-SR.md

* Rename docs/rs/index.md to docs/sr/index.md

* change rs to sr

* added serbian

Co-authored-by: Alfredo Canziani <[email protected]>

* Add SR to README-XX.md, fix DL capitalisation

* [pt] Begin translation to Portuguese (#542)

* [pt_BR] Begin translation to Brazilian Portuguese.

* Accomodate changes

* Update README-PT.md

Co-authored-by: Alfredo Canziani <[email protected]>

* Add PT to all README-XX.md

* Replace Piazza with Reddit for SR

* Figure name fix [EN]14-1.md (#701)

Issue #461

* Update 03-2.md

* Update 03-3.md

* Update 06-1.md

* Update 06-2.md

* Update 06-3.md

* Update 06.md

* Update 07-2.md

* Update 07.md

* Update 09-1.md

* Update 09-3.md

* Update 09.md

* Update 10-1.md

* Update 10-2.md

* Update 10-3.md

* Update 10.md

* Update 11.md

* Update 12-1.md

* Update 12-2.md

* Update 12-3.md

* Update 12.md

* Update 13-1.md

* Update 13-2.md

* Update 13-3.md

* Update 13.md

* Update 14-1.md

* Update 14-2.md

* Update 14-3.md

* Update 14.md

* Update 11-3.md

* Update 11-2.md

* Update 11-1.md

* Update _config.yml

* [JA] translation of week01, week02, week03, week06, week08, week09, week10, week11 , week12, week13 and week14 (#700)

* add week07 drafts

* Update 07-1.md

* Update 07-2.md

* Update 07-3.md

* Update 07.md

* Update _config.yml

* japanese translation week11

* japanese translation week11

* add week7

* add week07 & week11

* add week11 & week14

* add week12

* add week13

* add week06

* add week09

* add week10

* modify week14

* add week02

* add week01

* add week03

* add week08 (Jesmer Wong)

* review and modify week01

* add week02/02.md

* review and modify week02

* Update 03-2.md

* Update 03-3.md

* Update 06-1.md

* Update 06-2.md

* Update 06-3.md

* Update 06.md

* Update 07-2.md

* Update 07.md

* Update 09-1.md

* Update 09-3.md

* Update 09.md

* Update 10-1.md

* Update 10-2.md

* Update 10-3.md

* Update 10.md

* Update 11.md

* Update 12-1.md

* Update 12-2.md

* Update 12-3.md

* Update 12.md

* Update 13-1.md

* Update 13-2.md

* Update 13-3.md

* Update 13.md

* Update 14-1.md

* Update 14-2.md

* Update 14-3.md

* Update 14.md

* Update 11-3.md

* Update 11-2.md

* Update 11-1.md

* Update _config.yml

Co-authored-by: Alfredo Canziani <[email protected]>

* [JA] missing lang bug fix

* [RU] 12-2, 12-1, 12-3, 12 tranlsation, index fix, [EN] 12-3 fix (#703)

* 12 week translation started

* 12-1 init

* 12-1 translation fixes

* [RU] translation of 12-1.md

* [RU] index fixed 15th week added

* [RU] 12-2 translated

* [RU] 12-3 translation

* [EN] 12-3 fixes

* [RU] config fixes

Co-authored-by: Alfredo Canziani <[email protected]>

* Update 01-1.md (#706)

* Update 01.md (#707)

* Update index.md (#708)

* Update 01-2.md (#709)

* Update 01-3.md (#710)

* [VI] Create 02.md (#711)

* Create 02.md

* Update _config.yml

Co-authored-by: Alfredo Canziani <[email protected]>

* [JA] Add week 13-15 and #639 translation (#712)

Disclaimer partially rewritten for Japanese translation

* [BN] Beginning translations to Bengali (#677)

* Added README-BN.md and index.md for Bengali translation

* Added translation of 01.md

* Added Bengali section

* Added Bengali flag

* Added Bengali Flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

* Added Bengali flag

Co-authored-by: Alfredo Canziani <[email protected]>

* Fix BN index

* [SR] Minor fixes + remarks about Serbian translation (#714)

* Minor fix in README

* Minor fixes to serbian index page.

* Update README-BN.md (#718)

* [BN] Translation of week02-1 and homepage disclaimer (#716)

* [BN] Week02-1 translation

* [BN] Week02-1 translation

* [BN] homepage disclaimer translation

* [BN] weel2-1 comment added

* [BN] week02.md translated

* Update _config.yml

Co-authored-by: Alfredo Canziani <[email protected]>

* [RU] Week 10 (part 1) (#719)

* First part of week 10.

* Cамостоятельное обучение.

* Address comments.

* Update 10-1.md

* Update 10.md

Co-authored-by: Kateryna Solonko <[email protected]>
Co-authored-by: Alfredo Canziani <[email protected]>

* review and modify week04

* review and modify week05

Co-authored-by: Alfredo Canziani <[email protected]>
Co-authored-by: Tan Huynh <[email protected]>
Co-authored-by: Happy Sugar Life <[email protected]>
Co-authored-by: Ema Pajić <[email protected]>
Co-authored-by: Ricardo Barros Lourenço <[email protected]>
Co-authored-by: Yujin Chung <[email protected]>
Co-authored-by: Eugene <[email protected]>
Co-authored-by: Xiao Zeng <[email protected]>
Co-authored-by: CodTan <[email protected]>
Co-authored-by: Petar Veličković <[email protected]>
Co-authored-by: Kishor Datta Gupta <[email protected]>
Co-authored-by: Khalid Saifullah <[email protected]>
Co-authored-by: katesolonko <[email protected]>
Co-authored-by: Kateryna Solonko <[email protected]>
@marcozullich
Copy link
Contributor

I see now that the fig. numbers should be fine, is it @marofmar ?
Now I guess we'd have to put some captions on the images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants