From d829d83a5d7fa8edd7aa0175f43abeefecfcabec Mon Sep 17 00:00:00 2001 From: umothadaka Date: Mon, 10 Jun 2024 12:34:41 -0500 Subject: [PATCH] Addressed pr-comments --- .github/workflows/go-build.yml | 1 - pkg/controller/controller.go | 2 +- pkg/cron/cron.go | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/go-build.yml b/.github/workflows/go-build.yml index 96d4da3..44681c5 100644 --- a/.github/workflows/go-build.yml +++ b/.github/workflows/go-build.yml @@ -4,7 +4,6 @@ on: push: branches: - master - - udaymothadaka-patch-1 pull_request: branches: - master diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go index 820a4c4..646077b 100644 --- a/pkg/controller/controller.go +++ b/pkg/controller/controller.go @@ -297,7 +297,7 @@ func (c *Controller) zmsGetSignedDomains(domain string) (*zms.SignedDomains, boo d := zms.DomainName(domain) master := false conditions := false - signedDomain, _, err := c.zmsClient.GetSignedDomains(d, "", "", &master,&conditions, "") + signedDomain, _, err := c.zmsClient.GetSignedDomains(d, "", "", &master, &conditions, "") if err != nil { return nil, false, err } diff --git a/pkg/cron/cron.go b/pkg/cron/cron.go index 380a9e0..d1029fe 100644 --- a/pkg/cron/cron.go +++ b/pkg/cron/cron.go @@ -97,7 +97,7 @@ func notifyOnErr(err error, backoffDelay time.Duration) { func (c *Cron) requestCall() error { master := false conditions := false - domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master,&conditions, c.etag) + domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master, &conditions, c.etag) if err != nil { return fmt.Errorf("Error getting latest updated domains from ZMS API. Error: %v", err) }