Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safeguards for different column names in groups.csv file? #55

Open
hollyannperryman opened this issue May 10, 2022 · 0 comments
Open

Safeguards for different column names in groups.csv file? #55

hollyannperryman opened this issue May 10, 2022 · 0 comments

Comments

@hollyannperryman
Copy link

Hei! I tried to run the compare() function for the Gulf of Mexico files, and the function did not run and I think it is because the compare() function expects the column names to be specific labels (line 85; grp <- grp[grp$isturnedon == 1, c('code', 'name', 'longname', 'grouptype', 'numcohorts')]), but for the Gulf of Mexico inputs we have "Long Name" and "InvertType" and "NumCohorts". This file still runs in Atlantis, so I am guessing Atlantis has some safe-guards in place for different column headers in the groups.csv file. I do not have an issue changing the column headers, but then it needs to be communicated back to all the users of this model which might be tricky to make sure they use this new file. So, I am just wondering if this function should have some of those safe guards for different column headers? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant