Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Atom taking lot of CPU when flow bin version is not the same as flowconfig version #114

Open
MoOx opened this issue Jul 6, 2016 · 13 comments · May be fixed by #139
Open

Atom taking lot of CPU when flow bin version is not the same as flowconfig version #114

MoOx opened this issue Jul 6, 2016 · 13 comments · May be fixed by #139

Comments

@MoOx
Copy link

MoOx commented Jul 6, 2016

Eg: flow version is 0.28
.flowconfig [version] is 0.27

AtomHelper takes 100% of CPU.

When running flow in CLI

Launching Flow server for /.../project
Wrong version of Flow. The config specifies version 0.27.0 but this is version 0.28.0
Could not start Flow server!

I guess this plugin does not handle this case correctly and try again and again?
@nmn
Copy link
Contributor

nmn commented Jul 7, 2016

This sounds like an error I caused. I'll fix it soon. As of now the fix is to go to the terminal and manually start the flow server for the current version.

@Arcanemagus Arcanemagus mentioned this issue Aug 16, 2016
Closed
@cristian-sima
Copy link

@nmn Anything on this?

@nmn
Copy link
Contributor

nmn commented Sep 6, 2016

Sorry I've been on vacation. I'll fix this today.

@cristian-sima
Copy link

cristian-sima commented Sep 7, 2016 •
edited
Loading

Great. I hope you've had a great vacation time. Waiting for the fix ⏩

@ericnkatz
Copy link

Anything I can do to help fix this?

@cristian-sima
Copy link

I will be glad if you can do anything to solve this 👍

@ericnkatz
Copy link

ericnkatz commented Sep 23, 2016 •
edited
Loading

As of now the fix is to go to the terminal and manually start the flow server for the current version.

As of today this is still the best solution to side step this issue.

Not sure this has anything to do with [version] since I haven't even set [version] in my flowconfig.

nmn added a commit that referenced this issue Sep 24, 2016
@nmn
fix(error-handling): Don't re-check flow for any error.
e1157fb 
The linter used to recheck flow when the server was initializing.
This could cause massive CPU usage.

closes #114
@nmn nmn linked a pull request Sep 24, 2016 that will close this issue
Open
@cristian-sima
Copy link

Guys I solved it.

So, I deleted my absolute path to flow.js. Then I inserted this path ./node_modules/.bin/flow

And it does not consume memory and it works !!!

@cristian-sima
Copy link

I feel it was a somehow conflict between my absolute flow.exe and the node version from bin folder

@proProbe
Copy link

proProbe commented Apr 8, 2017

hello!
Any updates on this?

@nmn
Copy link
Contributor

nmn commented Apr 10, 2017

Sorry, been busy. But I am working on this, Promise!

@cristian-sima
Copy link

Waiting :D

@nmn
Copy link
Contributor

nmn commented Apr 25, 2017

I'm working with the Flow team to figure some things out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(error-handling): Don't re-check flow for any error. AtomLinter/linter-flow
5 participants
@ericnkatz @MoOx @nmn @proProbe @cristian-sima