Skip to content

Fixes to memory leaks identified in #325 #471

Fixes to memory leaks identified in #325

Fixes to memory leaks identified in #325 #471

Triggered via pull request March 13, 2024 09:37
Status Success
Total duration 2m 8s
Artifacts

coverage.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

18 warnings
[clippy] src/dds/pubsub.rs#L798: src/dds/pubsub.rs#L798
warning: bound is defined in more than one place --> src/dds/pubsub.rs:798:28 | 798 | pub fn create_datareader<D: 'static, SA>( | ^ ... 804 | D: Keyed, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
[clippy] src/dds/pubsub.rs#L810: src/dds/pubsub.rs#L810
warning: bound is defined in more than one place --> src/dds/pubsub.rs:810:32 | 810 | pub fn create_datareader_cdr<D: 'static>( | ^ ... 816 | D: serde::de::DeserializeOwned + Keyed, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/dds/pubsub.rs#L864: src/dds/pubsub.rs#L864
warning: bound is defined in more than one place --> src/dds/pubsub.rs:864:54 | 864 | pub fn create_simple_datareader_no_key<D: 'static, DA: 'static>( | ^^ ... 870 | DA: adapters::no_key::DeserializerAdapter<D>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/dds/pubsub.rs#L877: src/dds/pubsub.rs#L877
warning: bound is defined in more than one place --> src/dds/pubsub.rs:877:39 | 877 | pub fn create_datareader_no_key_cdr<D: 'static>( | ^ ... 883 | D: serde::de::DeserializeOwned, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/dds/pubsub.rs#L890: src/dds/pubsub.rs#L890
warning: bound is defined in more than one place --> src/dds/pubsub.rs:890:59 | 890 | pub(crate) fn create_datareader_with_entity_id_with_key<D: 'static, SA>( | ^ ... 898 | D: Keyed, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/dds/pubsub.rs#L995: src/dds/pubsub.rs#L995
warning: bound is defined in more than one place --> src/dds/pubsub.rs:995:33 | 995 | fn create_datareader_internal<D: 'static, SA>( | ^ ... 1004 | D: Keyed, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/dds/pubsub.rs#L1019: src/dds/pubsub.rs#L1019
warning: bound is defined in more than one place --> src/dds/pubsub.rs:1019:40 | 1019 | fn create_simple_datareader_internal<D: 'static, SA>( | ^ ... 1028 | D: Keyed, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/dds/pubsub.rs#L1228: src/dds/pubsub.rs#L1228
warning: bound is defined in more than one place --> src/dds/pubsub.rs:1228:28 | 1228 | pub fn create_datareader<D: 'static, SA>( | ^ ... 1237 | D: Keyed, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
[clippy] src/discovery/discovery_db.rs#L179: src/discovery/discovery_db.rs#L179
warning: unnecessary use of `get(&guid.prefix).is_none()` --> src/discovery/discovery_db.rs:179:33 | 179 | if self.participant_proxies.get(&guid.prefix).is_none() { | -------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!self.participant_proxies.contains_key(&guid.prefix)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
[clippy] src/discovery/spdp_participant_data.rs#L113: src/discovery/spdp_participant_data.rs#L113
warning: assigning the result of `Clone::clone()` may be inefficient --> src/discovery/spdp_participant_data.rs:113:7 | 113 | proxy.multicast_locator_list = self.default_multicast_locators.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `proxy.multicast_locator_list.clone_from(&self.default_multicast_locators)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default
[clippy] src/discovery/spdp_participant_data.rs#L114: src/discovery/spdp_participant_data.rs#L114
warning: assigning the result of `Clone::clone()` may be inefficient --> src/discovery/spdp_participant_data.rs:114:7 | 114 | proxy.unicast_locator_list = self.default_unicast_locators.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `proxy.unicast_locator_list.clone_from(&self.default_unicast_locators)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
[clippy] src/discovery/spdp_participant_data.rs#L116: src/discovery/spdp_participant_data.rs#L116
warning: assigning the result of `Clone::clone()` may be inefficient --> src/discovery/spdp_participant_data.rs:116:7 | 116 | proxy.multicast_locator_list = self.metatraffic_multicast_locators.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `proxy.multicast_locator_list.clone_from(&self.metatraffic_multicast_locators)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
[clippy] src/discovery/spdp_participant_data.rs#L117: src/discovery/spdp_participant_data.rs#L117
warning: assigning the result of `Clone::clone()` may be inefficient --> src/discovery/spdp_participant_data.rs:117:7 | 117 | proxy.unicast_locator_list = self.metatraffic_unicast_locators.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `proxy.unicast_locator_list.clone_from(&self.metatraffic_unicast_locators)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
[clippy] src/discovery/spdp_participant_data.rs#L145: src/discovery/spdp_participant_data.rs#L145
warning: assigning the result of `Clone::clone()` may be inefficient --> src/discovery/spdp_participant_data.rs:145:7 | 145 | proxy.unicast_locator_list = self.metatraffic_unicast_locators.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `proxy.unicast_locator_list.clone_from(&self.metatraffic_unicast_locators)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
[clippy] src/discovery/spdp_participant_data.rs#L148: src/discovery/spdp_participant_data.rs#L148
warning: assigning the result of `Clone::clone()` may be inefficient --> src/discovery/spdp_participant_data.rs:148:7 | 148 | proxy.unicast_locator_list = self.default_unicast_locators.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `proxy.unicast_locator_list.clone_from(&self.default_unicast_locators)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
[clippy] src/rtps/rtps_reader_proxy.rs#L102: src/rtps/rtps_reader_proxy.rs#L102
warning: assigning the result of `Clone::clone()` may be inefficient --> src/rtps/rtps_reader_proxy.rs:102:7 | 102 | self.multicast_locator_list = update.multicast_locator_list.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.multicast_locator_list.clone_from(&update.multicast_locator_list)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
[clippy] src/ros2/ros_node.rs#L242: src/ros2/ros_node.rs#L242
warning: assigning the result of `Clone::clone()` may be inefficient --> src/ros2/ros_node.rs:242:11 | 242 | *rpi2 = rpi.nodes().clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `rpi2.clone_from(rpi.nodes())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
coverage
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1