Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement event::Source for DataReader and DataWriter #204

Closed
fgadaleta opened this issue Jun 13, 2022 · 2 comments
Closed

Implement event::Source for DataReader and DataWriter #204

fgadaleta opened this issue Jun 13, 2022 · 2 comments

Comments

@fgadaleta
Copy link

IMHO this would allow DataReader and DataWriter to be wrapped in Arc<Mutex<>>
@jhelovuo
Copy link
Member

I do not understand this request. There are several unclear points:

  • In a previous issue DataWriter failed: OutOfResources #202 you state that you are already doing this wrapping.
  • How does it fail now?
  • What makes you think that implementing mio::event::Source would help?
  • Implementing Source requires an underlying system file/socket handle. How would you arrange this for a DataReader?

@jhelovuo
Copy link
Member

This seems to be done since Release 0.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fgadaleta @jhelovuo