Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unknown-pragmas warnings in a header file with GCC on Github Actions CI #80

Open
Zylann opened this issue Jan 8, 2022 · 0 comments
Open

Comments

@Zylann
Copy link

Zylann commented Jan 8, 2022

On my Github Actions CI I get warnings while compiling FastNoise2 on the ubuntu-20.04 image:

modules/voxel/thirdparty/fast_noise_2/include/FastNoise/Metadata.h:10: error: ignoring #pragma warning  [-Werror=unknown-pragmas]
   10 | #pragma warning( push )
      | 
modules/voxel/thirdparty/fast_noise_2/include/FastNoise/Metadata.h:11: error: ignoring #pragma warning  [-Werror=unknown-pragmas]
   11 | #pragma warning( disable : 4251 )
      | 
In file included from modules/voxel/thirdparty/fast_noise_2/src/FastNoise/FastNoise_C.cpp:3:
modules/voxel/thirdparty/fast_noise_2/include/FastNoise/Metadata.h:229: error: ignoring #pragma warning  [-Werror=unknown-pragmas]
  229 | #pragma warning( pop )
      | 

It should be noted I compile the library as part of Godot, it is neither a dynamic lib nor a static lib. I translated the CMake files to Godot's build system and it works fine, however I haven't seen anything related to silencing such warnings.
Either way, this is in a header file.

Could it be due to a version of GCC not supported by the library? A Microsoft-specific feature? Could this be wrapped into conditionals?

Quick search found this microsoft/DirectXMath#133 (comment)

@Zylann Zylann changed the title Warnings with GCC on Github Actions CI Warnings in a header file with GCC on Github Actions CI Jan 8, 2022
@Zylann Zylann changed the title Warnings in a header file with GCC on Github Actions CI unknown-pragmas warnings in a header file with GCC on Github Actions CI Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant