Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeng-Hu Hoverbeds #19152

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

1Sparky1
Copy link
Contributor

@1Sparky1 1Sparky1 commented May 13, 2024

Adds Zeng-Hu Hoverbeds, which are now less of a novelty and more practically helpful due to the stairs changes. They can be sourced from R&D, and the First Responders start with two to share between themselves.

Adds Zeng-Hu Hoverbeds, which are now less of a novelty and more practically helpful due to the stairs changes. They can be sourced from R&D, and the First Responders start with two to share between themselves.
@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label May 13, 2024
@github-actions github-actions bot added the 🗺️ Mapping - Horizon The PR touches the Horizon map files. label May 13, 2024
@1Sparky1
Copy link
Contributor Author

!review

@FluffyGhoster
Copy link
Contributor

I think the FRs starting with them basically circumvents the whole added mechanic

If you want to make them buildable eg. by science that's fine, but them being present at roundstart is a no from me

@1Sparky1
Copy link
Contributor Author

I don't think 2 beds circumvents the whole mechanic - Most FRs carry at least 2 to my knowledge, and these would be split between them. And anyone doing medical retrieval to fill in for a missing FR would have to deal with the stairs still.

I also don't think making them exclusively research is beneficial to anyone - Just printing things isn't in itself a particularly satisfying experience, and it would mean a science- and/or mining-less medical would suffer heavily (i.e. low pop would almost never get to use them)

@FluffyGhoster
Copy link
Contributor

I don't think 2 beds circumvents the whole mechanic - Most FRs carry at least 2 to my knowledge, and these would be split between them. And anyone doing medical retrieval to fill in for a missing FR would have to deal with the stairs still.

You can only transport a single patient at a time, so yes in essence it bypasses the mechanic, when you reach the GTR you unload the patient on another bed and go back out, thus bypassing the need to account for the stairs/elevators

I also don't think making them exclusively research is beneficial to anyone - Just printing things isn't in itself a particularly satisfying experience, and it would mean a science- and/or mining-less medical would suffer heavily (i.e. low pop would almost never get to use them)

We have various things exclusively research [sic], the IMS for surgeons for example; R&D is supposed to make and give improvements and QoL things, if people have fancy things by default, that reduces the utility of having R&D, thus lowering the amount of people that want to play it, and the loop continues

@github-actions github-actions bot removed the 🗺️ Mapping - Horizon The PR touches the Horizon map files. label May 14, 2024
@1Sparky1
Copy link
Contributor Author

While I'm still of two minds, I'd rather see the item in game soon and have the debate over starting beds or not at another time, so I've removed the initial ones.

@BotBOREALIS BotBOREALIS added the Waiting Period The PR has the required number of reviews, but is still in the waiting period label May 15, 2024
@DreamySkrell
Copy link
Contributor

I think FRs starting with two of these beds is fine - it's just FRs, everyone else would still have normal beds, so it's not really ignoring the stairs mechanics.

@BotBOREALIS BotBOREALIS added Awaiting Merge and removed Review Required Waiting Period The PR has the required number of reviews, but is still in the waiting period labels May 16, 2024
Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that they (obviously) use power, they should have inbuilt powercells and all the mechanics that come with it:

  • Adding/Removing the powercell
  • EMP-able -> Discharges the powercell
  • Hover function shutting down (ideally abruptly) if power runs out
  • A warning before the power runs out

@Arrow768 Arrow768 added Changes Required The PR requires changes before it can be approved and/or merged. and removed Awaiting Merge labels May 19, 2024
@1Sparky1 1Sparky1 requested a review from Arrow768 May 19, 2024 17:26
Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Required The PR requires changes before it can be approved and/or merged. Merge Conflict Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants