Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Kataphract Shuttle Docking Issues #19162

Merged
merged 2 commits into from
May 19, 2024

Conversation

EJDenton
Copy link
Contributor

Corrected Dock Target, verified vars, and removed extra docking controller to resolve the Kataphract shuttle not docking properly.

Fixes #19059

…oller to resolve the Kataphract shuttle not docking properly.
@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label May 15, 2024
@EJDenton
Copy link
Contributor Author

!bugfix

@BotBOREALIS BotBOREALIS added the Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. label May 15, 2024
@EJDenton
Copy link
Contributor Author

!review

@DreamySkrell
Copy link
Contributor

image
this is replacing airlock markers defined in code with markers defined in the map
the fixes (changing IDs or whatever) should be done on markers defined in code instead

@DreamySkrell DreamySkrell added the Changes Required The PR requires changes before it can be approved and/or merged. label May 15, 2024
@EJDenton
Copy link
Contributor Author

EJDenton commented May 15, 2024

@DreamySkrell I made the requested changes but I didn't see a way to re-request the review of changes that I've used in the past. Hopefully this message is enough.

@DreamySkrell DreamySkrell removed the Changes Required The PR requires changes before it can be approved and/or merged. label May 16, 2024
@Arrow768 Arrow768 added this pull request to the merge queue May 19, 2024
Merged via the queue into Aurorastation:master with commit af317a8 May 19, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Kataphract shuttle has no airlock sensor, kataphract docking port doesn't work.
4 participants